All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "J. Neuschäfer via buildroot" <buildroot@buildroot.org>
Cc: "J. Neuschäfer" <j.neuschaefer@gmx.net>,
	"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
	"Grzegorz Blach" <grzegorz@blach.pl>,
	"James Hilliard" <james.hilliard1@gmail.com>
Subject: Re: [Buildroot] [PATCH RFC 1/2] package/python-pillow: install libImaging headers
Date: Sun, 28 Dec 2025 00:14:15 +0100	[thread overview]
Message-ID: <20251228001415.0335f4c0@windsurf> (raw)
In-Reply-To: <20251226-rgbmatrix-bump-v1-1-69c2aa62beaa@gmx.net>

Hello J,

Thanks for your patch!

On Fri, 26 Dec 2025 17:07:10 +0100
J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:

> python-rgbmatrix depends[1] on Imaging.h since commit bf45676 ("Refactor
> broken unsafe SetImagePillow()").

You should clarify here: "and therefore changing python-pillow to
install this header is needed prior to bumping python-rgbmatrix".

> Debian only installs four headers[2], but this seems insufficient,
> because Imaging.h includes at least one header that is not on this list
> (Arrow.h).
> 
> [1]: https://github.com/hzeller/rpi-rgb-led-matrix/pull/1818

Please point to the commit that has been merged, not some "random" PR.

> [2]: https://sources.debian.org/src/pillow/12.0.0-1/debian/rules#L106

Please add your Signed-off-by line here.

Curious: python-pillow would for me be a... Python module. And so would
be python-rgbmatrix. But with your patch, we install some C/C++
headers. So python-pillow includes a native library, and
python-rgbmatrix directly links against this library? How was it
working prior to this change?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-12-27 23:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-26 16:07 [Buildroot] [PATCH RFC 0/2] Update package/rpi-rgb-led-matrix J. Neuschäfer via buildroot
2025-12-26 16:07 ` [Buildroot] [PATCH RFC 1/2] package/python-pillow: install libImaging headers J. Neuschäfer via buildroot
2025-12-27 23:14   ` Thomas Petazzoni via buildroot [this message]
2025-12-28 18:53     ` J. Neuschäfer via buildroot
2025-12-28 19:09       ` Thomas Petazzoni via buildroot
2025-12-26 16:07 ` [Buildroot] [PATCH RFC 2/2] package/rpi-rgb-led-matrix: update to latest git version (2025-12-22) J. Neuschäfer via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251228001415.0335f4c0@windsurf \
    --to=buildroot@buildroot.org \
    --cc=angelo.compagnucci@gmail.com \
    --cc=grzegorz@blach.pl \
    --cc=j.neuschaefer@gmx.net \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.