From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7073727FD43 for ; Sun, 28 Dec 2025 20:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766952521; cv=none; b=T+8zAZ11gBGFP8MnLuNwrft6CA6CSpJsrlXvrNPU5zHmIFTo7X8SZzmbVMIwmjizf9eWTVuWnA1u4UpELLQxnNqitOqhzJSLU3iU+I50qWkygNqZD35TWdV20iwtcgyurElLrbDlM12yOqbzKPuRqxw4fA28osGpNylVHhY87bU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766952521; c=relaxed/simple; bh=XCQHYdq3spbZE86t6SluvclGO9w1CrqV32bMnR1uFeI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pbvHxCsKjKnUrGtmhr21WKKHEO0a8C7lZ14cnbpunxnokKo9z8WX/MoZ+akFi9sqPQepOOCF7CUYiRjshwq1IJWpQ+/DjN/mVEz6MNlTHihFucc00bPdbDLisPZ5pIEhUs8rOU+v8BqN1hK0YTGD9jjId70KlB+9e75E7sUUJb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=EeDbB9CB; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="EeDbB9CB" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1766952517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3m20kD7PwGCTH43gt8FUGu7YcWOl9a9RmHjQnwvr5Pg=; b=EeDbB9CBP2vXXxNv7zfy1bwigiEJl2TwUP7B9I+HtJGYEChqkblDNfLK0kuKle3aHDNvTC pgDtTTK5QZvD6hfS6u840V2zxZ5lz4mUsthpOEru/qN80PwPDflHasYJQl8lIDsPgNkQrV dwX/aWQ299Ke6BfzcfHKPc7YFDHEsxE= From: Denis Benato To: linux-kernel@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org, "Hans de Goede" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Luke D . Jones" , "Mateusz Schyboll" , =?UTF-8?q?Merthan=20Karaka=C5=9F?= , "Krzysztof Kozlowski" , "Denis Benato" , Denis Benato Subject: [PATCH v2 1/3] platform/x86: asus-wmi: explicitly mark more code with CONFIG_ASUS_WMI_DEPRECATED_ATTRS Date: Sun, 28 Dec 2025 21:08:00 +0100 Message-ID: <20251228200815.794265-2-denis.benato@linux.dev> In-Reply-To: <20251228200815.794265-1-denis.benato@linux.dev> References: <20251228200815.794265-1-denis.benato@linux.dev> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Be more explicit in code that will be excluded when compiling with CONFIG_ASUS_WMI_DEPRECATED_ATTRS disabled. Signed-off-by: Denis Benato --- drivers/platform/x86/asus-wmi.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 4aec7ec69250..a49447eff4f4 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -302,7 +302,11 @@ struct asus_wmi { u32 nv_temp_target; u32 kbd_rgb_dev; + +#if IS_ENABLED(CONFIG_ASUS_WMI_DEPRECATED_ATTRS) bool kbd_rgb_state_available; +#endif /* IS_ENABLED(CONFIG_ASUS_WMI_DEPRECATED_ATTRS) */ + bool oobe_state_available; u8 throttle_thermal_policy_mode; @@ -1060,6 +1064,7 @@ static const struct attribute_group kbd_rgb_mode_group = { }; /* TUF Laptop Keyboard RGB State **********************************************/ +#if IS_ENABLED(CONFIG_ASUS_WMI_DEPRECATED_ATTRS) static ssize_t kbd_rgb_state_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) @@ -1106,6 +1111,8 @@ static const struct attribute_group kbd_rgb_state_group = { .attrs = kbd_rgb_state_attrs, }; +#endif /* IS_ENABLED(CONFIG_ASUS_WMI_DEPRECATED_ATTRS) */ + static const struct attribute_group *kbd_rgb_mode_groups[] = { NULL, NULL, @@ -1861,8 +1868,11 @@ static int asus_wmi_led_init(struct asus_wmi *asus) if (asus->kbd_rgb_dev) kbd_rgb_mode_groups[num_rgb_groups++] = &kbd_rgb_mode_group; + +#if IS_ENABLED(CONFIG_ASUS_WMI_DEPRECATED_ATTRS) if (asus->kbd_rgb_state_available) kbd_rgb_mode_groups[num_rgb_groups++] = &kbd_rgb_state_group; +#endif /* IS_ENABLED(CONFIG_ASUS_WMI_DEPRECATED_ATTRS) */ asus->led_workqueue = create_singlethread_workqueue("led_workqueue"); if (!asus->led_workqueue) -- 2.52.0