Re: [PATCH v1 4/7] NFSD: Add a per-knfsd reusable encfh_buf

[kernel test robot <lkp@intel.com>]

Hi Benjamin,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on trondmy-nfs/linux-next linus/master v6.19-rc2 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Coddington/nfsd-Convert-export-flags-to-use-BIT-macro/20251228-010753
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/5b7bf494b1ec816111ab34416dcde85c0bc01a0a.1766848778.git.bcodding%40hammerspace.com
patch subject: [PATCH v1 4/7] NFSD: Add a per-knfsd reusable encfh_buf
config: um-allyesconfig (https://download.01.org/0day-ci/archive/20251229/202512290151.LBKUBvUx-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251229/202512290151.LBKUBvUx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512290151.LBKUBvUx-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/nfsd/nfsxdr.c: In function 'svcxdr_decode_fhandle':
>> fs/nfsd/nfsxdr.c:66:9: error: too few arguments to function 'fh_init'
      66 |         fh_init(fhp, NFS_FHSIZE);
         |         ^~~~~~~
   In file included from fs/nfsd/vfs.h:11,
                    from fs/nfsd/nfsxdr.c:8:
   fs/nfsd/nfsfh.h:256:1: note: declared here
     256 | fh_init(struct svc_fh *fhp, int maxsize, struct svc_rqst *rqstp)
         | ^~~~~~~


vim +/fh_init +66 fs/nfsd/nfsxdr.c

a887eaed2a96475 Chuck Lever 2020-10-23  48  
635a45d34706400 Chuck Lever 2020-11-17  49  /**
635a45d34706400 Chuck Lever 2020-11-17  50   * svcxdr_decode_fhandle - Decode an NFSv2 file handle
635a45d34706400 Chuck Lever 2020-11-17  51   * @xdr: XDR stream positioned at an encoded NFSv2 FH
635a45d34706400 Chuck Lever 2020-11-17  52   * @fhp: OUT: filled-in server file handle
635a45d34706400 Chuck Lever 2020-11-17  53   *
635a45d34706400 Chuck Lever 2020-11-17  54   * Return values:
635a45d34706400 Chuck Lever 2020-11-17  55   *  %false: The encoded file handle was not valid
635a45d34706400 Chuck Lever 2020-11-17  56   *  %true: @fhp has been initialized
635a45d34706400 Chuck Lever 2020-11-17  57   */
635a45d34706400 Chuck Lever 2020-11-17  58  bool
ebcd8e8b28535b6 Chuck Lever 2020-10-21  59  svcxdr_decode_fhandle(struct xdr_stream *xdr, struct svc_fh *fhp)
ebcd8e8b28535b6 Chuck Lever 2020-10-21  60  {
ebcd8e8b28535b6 Chuck Lever 2020-10-21  61  	__be32 *p;
ebcd8e8b28535b6 Chuck Lever 2020-10-21  62  
ebcd8e8b28535b6 Chuck Lever 2020-10-21  63  	p = xdr_inline_decode(xdr, NFS_FHSIZE);
ebcd8e8b28535b6 Chuck Lever 2020-10-21  64  	if (!p)
ebcd8e8b28535b6 Chuck Lever 2020-10-21  65  		return false;
ebcd8e8b28535b6 Chuck Lever 2020-10-21 @66  	fh_init(fhp, NFS_FHSIZE);
d8b26071e65e80a NeilBrown   2021-09-02  67  	memcpy(&fhp->fh_handle.fh_raw, p, NFS_FHSIZE);
ebcd8e8b28535b6 Chuck Lever 2020-10-21  68  	fhp->fh_handle.fh_size = NFS_FHSIZE;
ebcd8e8b28535b6 Chuck Lever 2020-10-21  69  
ebcd8e8b28535b6 Chuck Lever 2020-10-21  70  	return true;
ebcd8e8b28535b6 Chuck Lever 2020-10-21  71  }
ebcd8e8b28535b6 Chuck Lever 2020-10-21  72  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki