From: Yuto Ohnuki <ytohnuki@amazon.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Yuto Ohnuki <ytohnuki@amazon.com>
Subject: [PATCH] fs: remove stale and duplicate forward declarations
Date: Mon, 29 Dec 2025 07:14:01 +0000 [thread overview]
Message-ID: <20251229071401.98146-1-ytohnuki@amazon.com> (raw)
Remove the following unnecessary forward declarations from fs.h, which
improves maintainability.
- struct hd_geometry: became unused when block_device_operations was
moved to blkdev.h in commit 08f858512151 ("[PATCH] move
block_device_operations to blkdev.h")
- struct iovec: became unused when aio_read/aio_write were removed in
commit 8436318205b9 ("->aio_read and ->aio_write removed")
- struct iov_iter (line 1910): duplicate of the declaration at line 70,
added in commit 293bc9822fa9 ("new methods: ->read_iter()
and ->write_iter()")
Signed-off-by: Yuto Ohnuki <ytohnuki@amazon.com>
---
include/linux/fs.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index f5c9cf28c4dc..598096ec2dee 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -55,8 +55,6 @@ struct bdi_writeback;
struct bio;
struct io_comp_batch;
struct fiemap_extent_info;
-struct hd_geometry;
-struct iovec;
struct kiocb;
struct kobject;
struct pipe_inode_info;
@@ -1907,7 +1905,6 @@ struct dir_context {
*/
#define COPY_FILE_SPLICE (1 << 0)
-struct iov_iter;
struct io_uring_cmd;
struct offset_ctx;
--
2.50.1
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
next reply other threads:[~2025-12-29 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-29 7:14 Yuto Ohnuki [this message]
2025-12-30 12:20 ` [PATCH] fs: remove stale and duplicate forward declarations kernel test robot
2025-12-30 13:58 ` kernel test robot
2025-12-30 13:58 ` kernel test robot
2025-12-30 13:58 ` kernel test robot
2025-12-30 20:34 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251229071401.98146-1-ytohnuki@amazon.com \
--to=ytohnuki@amazon.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.