From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF9B331A45; Mon, 29 Dec 2025 16:33:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767025993; cv=none; b=X0NMdjhvPk3Eo5qvcXaFkYIeBfI14Sj32yi+dci3VTSwK2KrjrS46YkDBvAyd8Ep+RehifYBnUgopu6OazyuVWzFJNr62RGp6xvmGQd6ezZme69lsbb8ZQmGHjXjgLND30nLtuW3K3WaGKKwKMDP6mjnz1r8JfG8jnrPpv03G9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767025993; c=relaxed/simple; bh=d3Vvxh30wiWEHFfD7zh3TObBJi5lc2VZmYw6ZMOkgrk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pq0wOpK4Fd5zsTFPPnCtAel2lcopD83ZLRLvba1su63yYNQgWWk5orBkUfOWEzdRUa4EeehSJD5YjQ1Z3MCtkbeDczJgMcKt0BH3Cgu24dh2kJlONq2+R4YAdJXpGNYdqvnxt6LEz5+Ed71iVNF7pAXhe1bKuJkjeMMNOjjfvCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RaCvmjL8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RaCvmjL8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19B04C4CEF7; Mon, 29 Dec 2025 16:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767025993; bh=d3Vvxh30wiWEHFfD7zh3TObBJi5lc2VZmYw6ZMOkgrk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RaCvmjL84FJ5sc5h1EKm69s0aVl9VDaw03IUhi60HxtXym/QEJgaDG7PvdVTMIS/9 mD8FiEHwCB5/EtSbhH3vbh9mTrRJ6ljiFxH2yJEudySh0et0jWW1tC+KyUKAW4u84w V3uMhSe3YjbQ4DNIBgkzUrVonFsX8+cuC7y+95aM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Brian Masney , Miaoqian Lin , Johan Hovold , Bjorn Andersson Subject: [PATCH 6.18 408/430] soc: qcom: ocmem: fix device leak on lookup Date: Mon, 29 Dec 2025 17:13:30 +0100 Message-ID: <20251229160739.327726887@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251229160724.139406961@linuxfoundation.org> References: <20251229160724.139406961@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit b5c16ea57b030b8e9428ec726e26219dfe05c3d9 upstream. Make sure to drop the reference taken to the ocmem platform device when looking up its driver data. Note that holding a reference to a device does not prevent its driver data from going away so there is no point in keeping the reference. Also note that commit 0ff027027e05 ("soc: qcom: ocmem: Fix missing put_device() call in of_get_ocmem") fixed the leak in a lookup error path, but the reference is still leaking on success. Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver") Cc: stable@vger.kernel.org # 5.5: 0ff027027e05 Cc: Brian Masney Cc: Miaoqian Lin Signed-off-by: Johan Hovold Reviewed-by: Brian Masney Link: https://lore.kernel.org/r/20250926143511.6715-2-johan@kernel.org Signed-off-by: Bjorn Andersson Signed-off-by: Greg Kroah-Hartman --- drivers/soc/qcom/ocmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/soc/qcom/ocmem.c +++ b/drivers/soc/qcom/ocmem.c @@ -202,9 +202,9 @@ struct ocmem *of_get_ocmem(struct device } ocmem = platform_get_drvdata(pdev); + put_device(&pdev->dev); if (!ocmem) { dev_err(dev, "Cannot get ocmem\n"); - put_device(&pdev->dev); return ERR_PTR(-ENODEV); } return ocmem;