From: Rob Herring <robh@kernel.org>
To: James Calligeros <jcalligeros99@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, asahi@lists.linux.dev
Subject: Re: [PATCH v2 2/7] ASoC: dt-bindings: update tdm-slot.txt references to tdm-slot.yaml
Date: Mon, 29 Dec 2025 19:32:25 -0600 [thread overview]
Message-ID: <20251230013225.GA3037280-robh@kernel.org> (raw)
In-Reply-To: <20251221-tdm-idle-slots-v2-2-ed4d96413aec@gmail.com>
On Sun, Dec 21, 2025 at 07:35:58PM +1000, James Calligeros wrote:
> Ensure that all references to tdm-slot.txt have been updated to
> tdm-slot.yaml, and are schema-compliant.
>
> Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
> ---
> .../bindings/sound/imx-audio-card.yaml | 14 ++++++--------
> .../bindings/sound/simple-card.yaml | 14 ++------------
> 2 files changed, 8 insertions(+), 20 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> index 3c75c8c78987..eb702f48d694 100644
> --- a/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/imx-audio-card.yaml
> @@ -31,6 +31,12 @@ patternProperties:
> $ref: /schemas/types.yaml#/definitions/string
> maxItems: 1
>
> + dai-tdm-slot-num:
> + $ref: tdm-slot.yaml#/$defs/dai-tdm-slot-num
> +
> + dai-tdm-slot-width:
> + $ref: tdm-slot.yaml#/$defs/dai-tdm-slot-width
Drop these and add just '$ref: tdm-slot.yaml#' up a level (with
'properties').
You may need 'unevaluatedProperties' or you can put
'dai-tdm-slot-num: true' here if you want to define which properties are
used.
> +
> format:
> description: audio format.
> items:
> @@ -38,14 +44,6 @@ patternProperties:
> - i2s
> - dsp_b
>
> - dai-tdm-slot-num:
> - description: see tdm-slot.txt.
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> - dai-tdm-slot-width:
> - description: see tdm-slot.txt.
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> playback-only:
> description: link is used only for playback
> $ref: /schemas/types.yaml#/definitions/flag
> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
> index 533d0a1da56e..a14716b2732f 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
> @@ -27,14 +27,6 @@ definitions:
> description: dai-link uses bit clock inversion
> $ref: /schemas/types.yaml#/definitions/flag
>
> - dai-tdm-slot-num:
> - description: see tdm-slot.txt.
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> - dai-tdm-slot-width:
> - description: see tdm-slot.txt.
> - $ref: /schemas/types.yaml#/definitions/uint32
> -
> system-clock-frequency:
> description: |
> If a clock is specified and a multiplication factor is given with
> @@ -115,6 +107,8 @@ definitions:
>
> dai:
> type: object
> + $ref: tdm-slot.yaml#
> +
> properties:
> sound-dai:
> maxItems: 1
> @@ -133,10 +127,6 @@ definitions:
> bitclock-master:
> $ref: /schemas/types.yaml#/definitions/flag
>
> - dai-tdm-slot-num:
> - $ref: "#/definitions/dai-tdm-slot-num"
> - dai-tdm-slot-width:
> - $ref: "#/definitions/dai-tdm-slot-width"
> clocks:
> maxItems: 1
> system-clock-frequency:
>
> --
> 2.52.0
>
next prev parent reply other threads:[~2025-12-30 1:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 9:35 [PATCH v2 0/7] ASoC: basic support for configuring bus keepers James Calligeros
2025-12-21 9:35 ` [PATCH v2 1/7] ASoC: dt-bindings: convert tdm-slot to YAML James Calligeros
2025-12-30 1:35 ` Rob Herring
2025-12-21 9:35 ` [PATCH v2 2/7] ASoC: dt-bindings: update tdm-slot.txt references to tdm-slot.yaml James Calligeros
2025-12-30 1:32 ` Rob Herring [this message]
2025-12-21 9:35 ` [PATCH v2 3/7] ASoC: dt-bindings: add TDM slot idle mode properties James Calligeros
2025-12-30 1:38 ` Rob Herring
2025-12-21 9:36 ` [PATCH v2 4/7] ASoC: soc-dai: define possible idle TDM slot modes James Calligeros
2025-12-21 9:36 ` [PATCH v2 5/7] ASoC: soc-dai: add common operation to set TDM idle mode James Calligeros
2025-12-21 9:36 ` [PATCH v2 6/7] ASoC: tas2764: expose SDOUT bus keeper via set_tdm_idle operation James Calligeros
2025-12-21 9:36 ` [PATCH v2 7/7] ASoC: tas2770: expose SDOUT bus keeper via set_tdm_idle James Calligeros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251230013225.GA3037280-robh@kernel.org \
--to=robh@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jcalligeros99@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kevin-lu@ti.com \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.