All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org, Julien Olivain <ju.o@free.fr>,
	Mauro Condarelli <mc5686@mclink.it>
Subject: Re: [Buildroot] [PATCH 2/2] package/python-autobahn: bump to version 25.12.2
Date: Tue, 30 Dec 2025 14:03:27 +0100	[thread overview]
Message-ID: <20251230140327.3c5d6f66@windsurf> (raw)
In-Reply-To: <20251228234350.2887246-2-james.hilliard1@gmail.com>

Hello James,

On Sun, 28 Dec 2025 16:43:50 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:

> diff --git a/package/python-autobahn/Config.in b/package/python-autobahn/Config.in
> index 527416a3cd..ada62e1e3b 100644
> --- a/package/python-autobahn/Config.in
> +++ b/package/python-autobahn/Config.in
> @@ -1,38 +1,42 @@
>  config BR2_PACKAGE_PYTHON_AUTOBAHN
>  	bool "python-autobahn"
> +	depends on BR2_INSTALL_LIBSTDCPP # python-ujson
>  	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS # python-cryptography
> +	select BR2_PACKAGE_PYTHON_CBOR2 # runtime
>  	select BR2_PACKAGE_PYTHON_CFFI # runtime
>  	select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime
>  	select BR2_PACKAGE_PYTHON_HYPERLINK # runtime
> +	select BR2_PACKAGE_PYTHON_MSGPACK # runtime
>  	select BR2_PACKAGE_PYTHON_TXAIO # runtime
> +	select BR2_PACKAGE_PYTHON_UBJSON # runtime
> +	select BR2_PACKAGE_PYTHON_UJSON # runtime
>  	help
>  	  WebSocket client and server library, WAMP real-time
>  	  framework.
>  
>  	  https://pypi.python.org/pypi/autobahn
>  
> -if BR2_PACKAGE_PYTHON_AUTOBAHN
> +comment "python-autobahn needs a toolchain w/ C++"
> +	depends on !BR2_INSTALL_LIBSTDCPP

This lacked:

	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS

and also, you shouldn't put the comment between the main option and the
sub-options, as it breaks the indentation of the sub-options in
menuconfig. The comment should be *after* the sub-options.

Applied with this issue fixed.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-12-30 13:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-28 23:43 [Buildroot] [PATCH 1/2] package/python-base58: new package James Hilliard
2025-12-28 23:43 ` [Buildroot] [PATCH 2/2] package/python-autobahn: bump to version 25.12.2 James Hilliard
2025-12-30 13:03   ` Thomas Petazzoni via buildroot [this message]
2025-12-30 13:02 ` [Buildroot] [PATCH 1/2] package/python-base58: new package Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251230140327.3c5d6f66@windsurf \
    --to=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=ju.o@free.fr \
    --cc=mc5686@mclink.it \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.