From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [android-common:android16-6.12 2/2] mm/huge_memory.c:870 setup_thp_anon() error: strcpy() 'str' too large for 'str_dup' (1010102 vs 4096)
Date: Wed, 31 Dec 2025 17:02:11 +0800 [thread overview]
Message-ID: <202512311652.9mCXc1ig-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com
tree: https://android.googlesource.com/kernel/common android16-6.12
head: ecd8c13eebd9ac39eaa1b45d9fe23ff020c4e68c
commit: dd4d30d1cdbe826e6569b44453c2d9bb9424d234 [2/2] mm: override mTHP "enabled" defaults at kernel cmdline
:::::: branch date: 19 hours ago
:::::: commit date: 1 year, 4 months ago
config: i386-randconfig-141-20251231 (https://download.01.org/0day-ci/archive/20251231/202512311652.9mCXc1ig-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512311652.9mCXc1ig-lkp@intel.com/
smatch warnings:
mm/huge_memory.c:870 setup_thp_anon() error: strcpy() 'str' too large for 'str_dup' (1010102 vs 4096)
vim +870 mm/huge_memory.c
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 858
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 859 static char str_dup[PAGE_SIZE] __initdata;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 860 static int __init setup_thp_anon(char *str)
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 861 {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 862 char *token, *range, *policy, *subtoken;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 863 unsigned long always, inherit, madvise;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 864 char *start_size, *end_size;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 865 int start, end, nr;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 866 char *p;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 867
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 868 if (!str || strlen(str) + 1 > PAGE_SIZE)
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 869 goto err;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 @870 strcpy(str_dup, str);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 871
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 872 always = huge_anon_orders_always;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 873 madvise = huge_anon_orders_madvise;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 874 inherit = huge_anon_orders_inherit;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 875 p = str_dup;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 876 while ((token = strsep(&p, ";")) != NULL) {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 877 range = strsep(&token, ":");
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 878 policy = token;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 879
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 880 if (!policy)
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 881 goto err;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 882
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 883 while ((subtoken = strsep(&range, ",")) != NULL) {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 884 if (strchr(subtoken, '-')) {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 885 start_size = strsep(&subtoken, "-");
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 886 end_size = subtoken;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 887
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 888 start = get_order_from_str(start_size);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 889 end = get_order_from_str(end_size);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 890 } else {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 891 start = end = get_order_from_str(subtoken);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 892 }
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 893
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 894 if (start < 0 || end < 0 || start > end)
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 895 goto err;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 896
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 897 nr = end - start + 1;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 898 if (!strcmp(policy, "always")) {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 899 bitmap_set(&always, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 900 bitmap_clear(&inherit, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 901 bitmap_clear(&madvise, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 902 } else if (!strcmp(policy, "madvise")) {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 903 bitmap_set(&madvise, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 904 bitmap_clear(&inherit, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 905 bitmap_clear(&always, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 906 } else if (!strcmp(policy, "inherit")) {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 907 bitmap_set(&inherit, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 908 bitmap_clear(&madvise, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 909 bitmap_clear(&always, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 910 } else if (!strcmp(policy, "never")) {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 911 bitmap_clear(&inherit, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 912 bitmap_clear(&madvise, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 913 bitmap_clear(&always, start, nr);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 914 } else {
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 915 pr_err("invalid policy %s in thp_anon boot parameter\n", policy);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 916 goto err;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 917 }
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 918 }
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 919 }
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 920
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 921 huge_anon_orders_always = always;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 922 huge_anon_orders_madvise = madvise;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 923 huge_anon_orders_inherit = inherit;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 924 anon_orders_configured = true;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 925 return 1;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 926
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 927 err:
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 928 pr_warn("thp_anon=%s: error parsing string, ignoring setting\n", str);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 929 return 0;
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 930 }
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 931 __setup("thp_anon=", setup_thp_anon);
dd4d30d1cdbe826 Ryan Roberts 2024-08-14 932
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-12-31 9:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202512311652.9mCXc1ig-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.