From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7] app/testpmd: removed preconf Rx VLAN offloads Date: Wed, 31 Jan 2018 22:09:24 +0100 Message-ID: <2025687.oP9oAAUX4U@xps> References: <1517417958-30594-1-git-send-email-motih@mellanox.com> <1517419923-31711-1-git-send-email-motih@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, wenzhuo.lu@intel.com, techboard@dpdk.org To: Moti Haimovsky Return-path: In-Reply-To: <1517419923-31711-1-git-send-email-motih@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/01/2018 18:32, Moti Haimovsky: > Removed the hardcoded preconfigured Rx VLAN offload configuration > from testpmd and changed the Rx offload command line parameters from > disable to enable. > It has been decided by the Technical Board that testers who wish to > use these offloads will now have to explicitly write them in the > command-line when running testpmd. > Motivation: > Some PMDs such at the mlx4 may not implement all the offloads. > After the offload API rework assuming no offload is enabled by default, > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying > to enable a not supported offload is clearly an error which will cause > configuration failing. > > Considering that testpmd is an application to test the PMD, it should > not fail on a configuration which was not explicitly requested. > The behavior of this test application is then turned to an opt-in > model. > > Signed-off-by: Moti Haimovsky Acked-by: Thomas Monjalon Applied with added explanations about the Technical Board agreement. Thanks