From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E69D140759D for ; Wed, 27 May 2026 13:10:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779887404; cv=none; b=sErEMuEZMnMSPp10JyO7HJipZEZqcY3ipQIgk5NqrMXefPPfUWOz5IR6G6aaHL3A9w3n5IzyQM5Jczr/CdJ4kvTjsMZhL9Xog+1LDfTb1a2ZSNazE2eCwYpjOXU1G/dTJbBKvlm4OFm1lpSosjsuzu+Q62rbjvN8f0RjrbEKEF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779887404; c=relaxed/simple; bh=SRmk+8dKQHv1TNh+dPFDr7WBjwn/lnlQ8ebct8h++U8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jllg+0X8fFHc0hNvnw99UI4y8tIlaVLTdl/yM9Ox7dPXYA0f4C+RZY0XtD+5HIkviKNFNZoKYsHHiEhl8h/gwnG2C8UiQhwFVqwBSgxkmYkPAwTPNK9heYgfmiSfb6urrVhmw36ZmgbdM2PbMN5Fs9BIjk+agkkLTfY0q9/cDf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amutable.com; spf=pass smtp.mailfrom=amutable.com; dkim=pass (2048-bit key) header.d=amutable-com.20251104.gappssmtp.com header.i=@amutable-com.20251104.gappssmtp.com header.b=xNKmVEYv; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amutable.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amutable.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amutable-com.20251104.gappssmtp.com header.i=@amutable-com.20251104.gappssmtp.com header.b="xNKmVEYv" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-836ed29d1e5so5212339b3a.2 for ; Wed, 27 May 2026 06:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutable-com.20251104.gappssmtp.com; s=20251104; t=1779887402; x=1780492202; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+lmAr4thq2tof1olIb/7jHlzqPnQwHivVehmpTFmxWg=; b=xNKmVEYvecF1N703AjFuRxqy62uV7cG1KxTsNNZdaBo26YMH6qopSPTX0ZMngLz67W IPl0+ig4XsJpESisA3Upapn7MpO5+6y1uTv4Y3blopFEXSHUofpJ3ZA9s4Dae03o3CIj Hti+Dm81hbdvVLs6qeIt1Obm8gVmWIHex9eccnfqQzb9NNUhIgBFoIeIV/oacUr9Gu/w Go7jCkyga1O4awvcPnOhtteVVRoz8eSk2ES5WcSUyFJBJsAxATdMOddX/VSQ3g99PoMV 1F7yeiCUgr9BXnhgDn059W6wMlB1RujpxRQHLYQ9tbFCrFYYcAGwjRs4rskuPJFzEcIy thJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779887402; x=1780492202; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+lmAr4thq2tof1olIb/7jHlzqPnQwHivVehmpTFmxWg=; b=csLoRCWjFNROpn8mJub/p2hpkNxfg0FAAkymOjXuGvtSGVPBWEDK1ZpdsK1W/BG/3+ dcBAKLXeYKDm1CVkOLiD4x/oCcPYlJHY/iJteoMZU9MRV3MzaCqnoxC8txFrg0AMn+gx r7QFMF47Hi24qOZIqgh8r6nBN0rNQqWWoM3CI+C+ICMcljdN99OCj4mWcrEk901/DwXw c+65DKxt7rgZN18eox+QEyIrZlf/Ei5hR/Q5csuQtuWKWPp/DZi+sIaNeKtLlubQPqAf guL7IMGjqcOg5SXFTsp6GUy6UGWBz0nyOlvBFCBJBMQO7y/KKpIwAJcguc1WeT2pKvkQ TOow== X-Forwarded-Encrypted: i=1; AFNElJ/KhVk8phrmlxP1fkurfwFEnRk9ARR3FZWr3wqEFxlsBDgSEjVByP8P/OYSuhr5xU40G5Uev3gpd/tR86Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwWc9B9Z4DxHAq/pgAX+1ewcVyRBqvdtzbb6Xj3HKEhJO/VpYUb Tc1Xx6Yjl5wYrdS89ZakGhy5TySDT7gORDE+xDrGUC10PxZhl55ntMYPaSyLcGjUumlR X-Gm-Gg: Acq92OEejuIrERJVe6xsgjWh6k/Tv0ru5Oe/gd4dNzFuQqZ1R3Jeojf2NwVuHj0tDGM lOzpzGAPO9qe0yPYa5hptxd9/1aYq74uBss+qCFZ9kJtsQT+glQMm88mS5uJzZ/Dq7bbVx8WP7S vIVrDMo3cwhBxHIvtjvvlff/HkvwmPmA4ZScTw17MUfc7XSLcTF9fKyDtrKEsyEdvrdrSqdSNgn 5uEt+f4laUVpwtnh1zvws74dARzllwc9eZ+966Y5rgogkjym00t1oI/1HmduZqWWmNbsQISkTiq nw5b7zWecOMnY2H3ZWvVAz3q+lAiqp0LPtDJ5llqo59jpnFHQjHOD9Pcss9/G/fNbMCY3lUtVWs uAqT0DldMKpDskV8GGQ/4TF8EaTxySGoFBHIwb4b59Cc0OdISIbsPip9v4ccE9qvADR8BH4XdUy /DDBsYmRNGniIFl5X5OPNPUP6XM5To2XQwgZhQKXtio1tcj4jkyX+pIqgcG2DZ7IGu0MmTFWav9 tTxezYNEIy3RdC13pofnco= X-Received: by 2002:a05:6a00:908b:b0:83d:446c:2a8c with SMTP id d2e1a72fcca58-8415f406c9amr22485922b3a.25.1779887401663; Wed, 27 May 2026 06:10:01 -0700 (PDT) Received: from amutable.com (2403-5809-a2fc-2-a90-9fd7-aedd-d405.ip6.aussiebb.net. [2403:5809:a2fc:2:a90:9fd7:aedd:d405]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d6eb0587sm2355259b3a.21.2026.05.27.06.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 06:10:00 -0700 (PDT) Date: Wed, 27 May 2026 23:09:44 +1000 From: Aleksa Sarai To: Christian Brauner Cc: Jori Koolstra , Mark Brown , Dorjoy Chowdhury , Jeff Layton , Linux Kernel Mailing List , Linux Next Mailing List , Aleksa Sarai Subject: Re: linux-next: build failure after merge of the vfs-brauner tree Message-ID: <2026-05-27-yapping-angled-spoof-tunic-AYfaAV@amutable.com> References: <1286370201.1726989.1779131564699@kpc.webmail.kpnmail.nl> <4bd253fa-c363-43cb-adaa-0248ac707a0d@sirena.org.uk> <12198575.2129298.1779371885282@kpc.webmail.kpnmail.nl> <20260527-bordstein-reizt-gemindert-a76319be86a1@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260527-bordstein-reizt-gemindert-a76319be86a1@brauner> On 2026-05-27, Christian Brauner wrote: > On Thu, May 21, 2026 at 03:58:05PM +0200, Jori Koolstra wrote: > > > > > Op 19-05-2026 18:24 CEST schreef Mark Brown : > > > > > > > > > On Mon, May 18, 2026 at 09:12:44PM +0200, Jori Koolstra wrote: > > > > > Op 18-05-2026 19:13 CEST schreef Mark Brown : > > > > > > > > Figured it'd be an arch specific version of a similar thing - I didn't > > > > > audit them as you can see. > > > > > > > These confusions with octal numbers in lists that aren't even ordered is > > > > why I would prefer to use shifted values instead. I don't see any reason > > > > actually why we should not just convert them all, apart from churning and > > > > perhaps not doing it correctly (which would be bad). My rationale for mixing > > > > was to use 1 << n at least for the remaining bits. If I remember correctly, > > > > this is also what Aleksa preferred. > > > > > > Yeah, shifted values do make sense to me as well - other than the > > > inconsistent style the only issue I saw was that it's a bit less obvious > > > that the values collide. > > > > Yeah, that's unfortunate. > > > > @Christian, can we get rid of these octal values? Or is that too much churn? > > Do it. If we could also get some comments in asm-generic that tell you which flag bits are "cursed", that would also be quite great. My impression is a fair number of people forget to check the arch-specific headers, so having a note in the generic one would let us avoid this issue in future (and IMHO will be more effective than just switching from octal). -- Aleksa Sarai Founding Engineer at Amutable https://www.cyphar.com/