All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>, Feng Ning <feng@innora.ai>
Subject: Re: [PATCH 6.18.y] staging: media: atomisp: use array3_size() for overflow-safe allocation
Date: Sat, 21 Nov 2026 10:27:42 -0500	[thread overview]
Message-ID: <2026-11-21-1-daily-reply-0014@kernel.org> (raw)
In-Reply-To: <e4e67ea4f7d14636a8bab81909764adc@innora.ai>

> The atomisp driver computes DVS, morphing table, shading table and
> statistics buffer sizes using unchecked arithmetic.  When the table
> dimensions are large, the product can silently wrap, causing kvmalloc()
> to allocate an undersized buffer.

The code is fine on all six trees, but please keep the upstream changelog of
d178c7ca8fef ("staging: media: atomisp: use array3_size() for overflow-safe
allocation") unchanged. Upstream says "When dimensions are attacker-controlled
or simply large".

> Backport note: these three files do not include <linux/overflow.h> in
> this tree yet, so the include is added here.  No other changes were
> made.

Huh? did you bother to double check your LLM?

Could you resend all six (6.18, 6.12, 6.6, 6.1, 5.15 and 5.10) with those
two changes?

-- 
Thanks,
Sasha

      reply	other threads:[~2026-11-21 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  0:13 [PATCH 6.18.y] staging: media: atomisp: use array3_size() for overflow-safe allocation Feng Ning
2026-11-21 15:27 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026-11-21-1-daily-reply-0014@kernel.org \
    --to=sashal@kernel.org \
    --cc=feng@innora.ai \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.