Re: [Buildroot] [PATCH v4 1/2] package/qoriq-restool: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: buildroot@buildroot.org,
	Brandon Maier <Brandon.Maier@collins.com>,
	Ioana Ciornei <ciorneiioana@gmail.com>,
	Romain Naour <romain.naour@smile.fr>,
	Vincent Jardin <vjardin@free.fr>, Julien Olivain <ju.o@free.fr>,
	Akhilesh Nema <nemaakhilesh@gmail.com>
Subject: Re: [Buildroot] [PATCH v4 1/2] package/qoriq-restool: new package
Date: Fri, 2 Jan 2026 23:27:25 +0100	[thread overview]
Message-ID: <20260102232725.178d3918@windsurf> (raw)
In-Reply-To: <20250830173313.164981-2-olteanv@gmail.com>

Hello,

On Sat, 30 Aug 2025 20:33:12 +0300
Vladimir Oltean <olteanv@gmail.com> wrote:

> Introduce a package for the restool program, which permits the user to
> modify the network configuration of the DPAA2 subsystem and create one
> that is adequate to their use case.
> 
> We integrate the master branch, which is effectively the
> lf-6.12.20-2.0.0 release tag, plus some extra fixups specifically made
> for the Buildroot integration:
> - commit b44748ed0bb3 ("Avoid use of non-portable __WORDSIZE when
>   defining BITS_PER_LONG")
> - commit b4a734f3512b ("restool: fix format string for 64 bit time_t in
>   parse_obj_command()")
> 
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> Reviewed-by: Vincent Jardin <vjardin@free.fr>

Thanks, I've applied, with minor tweaks.

> +	  The restool program is able to talk to the Management
> +	  Complex at runtime and permits the dynamic reconfiguration
> +	  of networking objects, as well as saving the current
> +	  configuration into a new DPL file. Without the restool
> +	  program, the only possible networking configuration is
> +	  that specified in the boot-time DPL file.
> +
> +	  https://github.com/nxp-qoriq/restool
> +	  # sign in required
> +	  https://www.nxp.com/webapp/Download?colCode=DPAA2UM

Dropped this last link as we want a reachable project homepage as the
last element of the help text.

> diff --git a/package/qoriq-restool/qoriq-restool.mk b/package/qoriq-restool/qoriq-restool.mk
> new file mode 100644
> index 000000000000..52a622f70e03
> --- /dev/null
> +++ b/package/qoriq-restool/qoriq-restool.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# qoriq-restool
> +#
> +################################################################################
> +
> +QORIQ_RESTOOL_VERSION = lf-6.12.20-2.0.0-3-gb44748e
> +QORIQ_RESTOOL_SITE = $(call github,nxp-qoriq,restool,$(QORIQ_RESTOOL_VERSION))
> +QORIQ_RESTOOL_LICENSE = BSD-3-Clause or GPL-2.0-or-later

s/GPL-2.0-or-later/GPL-2.0+/

because yeah we don't use exactly SPDX in Buildroot (maybe we should,
but for the time being, let's be consistent).

> +QORIQ_RESTOOL_LICENSE_FILES = LICENSE
> +
> +QORIQ_RESTOOL_MAKE_OPTS = \
> +	CC="$(TARGET_CC)" \
> +	CROSS_COMPILE="$(TARGET_CROSS)"
> +
> +define QORIQ_RESTOOL_BUILD_CMDS
> +	cd $(@D) && $(TARGET_MAKE_ENV) $(MAKE) $(QORIQ_RESTOOL_MAKE_OPTS)

Changed to:

+define QORIQ_RESTOOL_BUILD_CMDS
+       $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
+               CC="$(TARGET_CC)" \
+               CROSS_COMPILE="$(TARGET_CROSS)"
+endef

> +endef
> +
> +define QORIQ_RESTOOL_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) MANPAGE="" $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) \
> +		prefix=/usr install

Reformatted to:

+define QORIQ_RESTOOL_INSTALL_TARGET_CMDS
+       $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
+               MANPAGE="" DESTDIR=$(TARGET_DIR) \
+               prefix=/usr install
+endef

Just for consistency between both.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot