From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC0A42C9D; Fri, 2 Jan 2026 06:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767336564; cv=none; b=PZnt2JFbMgpCJby4jzHuISe89Wykr55Md3XDxMH1ytIWdThoifasgeytB4cYnkJsNaqujfnYVRhQPrUi5jIdULdpED4fD823OEBAvh4dvVYvArox8ljATHrLO+OfgKKrrYS7F7Uh1IwBTMnhTMr7N++bIGs6RS/rX4RFZ7XZRf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767336564; c=relaxed/simple; bh=9CSmys8ezuFn357Jd8v/8PwxpOSGQONYot1yTs+LqZU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OHck3jbAekzpjEtJDJnH9zheSR23zeuZeahO4yuLOGvXP1bhQYcXqAPT8f+Ulef/VxGP+Qqn7vypDrlkY7MnMVurY//um1T5aqIWkXhxPv0DB/NRm+lfp5ji6hJ9HpGfsHLc2ouVB+HCg5ssp169BoBXuvA1t0bH83q3BNKC+lE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=z32J0OH7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="z32J0OH7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92867C116B1; Fri, 2 Jan 2026 06:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767336564; bh=9CSmys8ezuFn357Jd8v/8PwxpOSGQONYot1yTs+LqZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=z32J0OH7AYdcFmf89kbxVl/0YrHs5qGmA42dglNocBZG+HYkdqoXtZ6qBKxC3dplY Vg7XTFfwuNT3wXago3pa+fxA8YIaoCt6nTE8pEwfz6ue9ZjyXa/E7+KwYEZzU/TD/X Y+YtC6dqcNjeNa6xjY7OeZfQSJ1r48wDMBA6IA4Y= Date: Fri, 2 Jan 2026 07:49:18 +0100 From: Greg Kroah-Hartman To: Stephen Zhang Cc: stable@vger.kernel.org, patches@lists.linux.dev, Andreas Gruenbacher , Sasha Levin Subject: Re: [PATCH 6.18 052/430] gfs2: Fix use of bio_chain Message-ID: <2026010240-certify-refined-7c02@gregkh> References: <20251229160724.139406961@linuxfoundation.org> <20251229160726.283681845@linuxfoundation.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Dec 31, 2025 at 07:54:45PM +0800, Stephen Zhang wrote: > Greg Kroah-Hartman 于2025年12月30日周二 00:16写道： > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Andreas Gruenbacher > > > > [ Upstream commit 8a157e0a0aa5143b5d94201508c0ca1bb8cfb941 ] > > > > In gfs2_chain_bio(), the call to bio_chain() has its arguments swapped. > > The result is leaked bios and incorrect synchronization (only the last > > bio will actually be waited for). This code is only used during mount > > and filesystem thaw, so the bug normally won't be noticeable. > > > > Reported-by: Stephen Zhang > > Signed-off-by: Andreas Gruenbacher > > Signed-off-by: Sasha Levin > > --- > > fs/gfs2/lops.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c > > index 9c8c305a75c46..914d03f6c4e82 100644 > > --- a/fs/gfs2/lops.c > > +++ b/fs/gfs2/lops.c > > @@ -487,7 +487,7 @@ static struct bio *gfs2_chain_bio(struct bio *prev, unsigned int nr_iovecs) > > new = bio_alloc(prev->bi_bdev, nr_iovecs, prev->bi_opf, GFP_NOIO); > > bio_clone_blkg_association(new, prev); > > new->bi_iter.bi_sector = bio_end_sector(prev); > > - bio_chain(new, prev); > > + bio_chain(prev, new); > > submit_bio(prev); > > return new; > > } > > -- > > Hi Greg, > > I believe this patch should be excluded from the stable series. Please > refer to the discussion in the linked thread, which clarifies the reasoning: > > https://lore.kernel.org/gfs2/tencent_B55495E8E88EEE66CC2C7A1E6FBC2FC16C0A@qq.com/T/#mad18b8492e01daa939c7d958200802c9603b6c73 What exactly is the reasoning? Why not just take these submitted patches when they hit Linus's tree as well? thanks, greg k-h