From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62C0BC2A06A for ; Sun, 4 Jan 2026 02:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:References:In-Reply-To: Message-ID:Date:To:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4RZKOnaS9BP8cikFVNmdOExf4b4jcEes3l3Y/roaAH0=; b=ea2XyAMtF1GlLAZjrE58Wl/UqB X+ZfhyCbobS1VVVbRf7oQL+IA5aOR7nHdebtYegk5cmQ7pD75smZiRPzpv0V2xv4yEfe76xmtjyWs UVvf41wHVXa2Tj+F/sLlMfL/9fI+LY+gnAkH7ySuaJtlkRIMF0bOMXTtF8F05pfAEWiE=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vcDXa-0000gE-0R; Sun, 04 Jan 2026 02:08:22 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vcDXX-0000g6-Uh for linux-f2fs-devel@lists.sourceforge.net; Sun, 04 Jan 2026 02:08:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GCtwMZPCIuHwYXV1QlFGo7TQumwb+CRMxnj5cuc99z0=; b=bCO9bkdb1yE4E+BpDiiqqVKAK2 //9YO1tRQ6Q2F3vQqGr/MKrHLbuGKeaTr4YrFSLELQFFr3LieuadvyHxCVAjRr9IQwlXMy/2fQgQM SW4s9SdmvmUeX9FyC6XndH1+c1GCq5/g/uH2FegdOhKgv3ATHMvd+um9iL9QOH88Vbkc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GCtwMZPCIuHwYXV1QlFGo7TQumwb+CRMxnj5cuc99z0=; b=LiwolfDxa6m1jraZJx6q9VfWwq JcBFsYNKhqgFjRJMwMskDkE7VLiGx7J8YY53rYIQ5cdxEfwbV13MHjUyWYQ1uiXOD6DsOmlLGXF+N /AeYYL6lgL5jBLOIILlwXfjnzilWuN6GG3rWL4ZOBDSb1PeEUO4rEZGbt45w/yRPZ0GQ=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vcDXX-0005nh-7D for linux-f2fs-devel@lists.sourceforge.net; Sun, 04 Jan 2026 02:08:19 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id EC0724427A for ; Sun, 4 Jan 2026 02:08:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CED15C19423; Sun, 4 Jan 2026 02:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767492488; bh=FjxPDkPb0b6ALOwmCLq6MsIiEbneVQ9Q1d4PppU8+tA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AWYRXeih4MO46MPjN3tbVqoxA2sd5j22OppBIBq+AzszC9hYySubS4DQqkybxblC1 HPqf2+L1joIJsijRio2y6QzWSBtV6yzEj4LZL1Cb1mqXH/FNMgCZmw7izV98rwRdhl dpuaE1XLOVvDcwyoH0M95wLXXtGV4uGatT8kqBnzktwUXcKRiXaU98MHkbYHnLN3hR 91UWAxdbvJeEnt2BKYvoIKjHFqnKvJyJQY6s2PW8GWHVrX+W8RlZg76cpTfu7Nv9vN 99buHy8MTNwVEsqhjhDXX1XZwioQzxSErhCEJFi+m4hBuUNcT6wyFza9JhtGPtrWlg SyilBMKlXuyiQ== To: jaegeuk@kernel.org Date: Sun, 4 Jan 2026 10:07:19 +0800 Message-ID: <20260104020729.1064529-4-chao@kernel.org> X-Mailer: git-send-email 2.52.0.358.g0dd7633a29-goog In-Reply-To: <20260104020729.1064529-1-chao@kernel.org> References: <20260104020729.1064529-1-chao@kernel.org> MIME-Version: 1.0 X-Headers-End: 1vcDXX-0005nh-7D Subject: [f2fs-dev] [PATCH 04/14] f2fs: trace elapsed time for node_change lock X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Use f2fs_{down,up}_read_trace for node_change to trace lock elapsed time. Signed-off-by: Chao Yu --- fs/f2fs/data.c | 4 ++-- fs/f2fs/f2fs.h | 1 + fs/f2fs/super.c | 2 +- include/trace/events/f2fs.h | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 73fcafbc8191..5469547142e7 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1472,7 +1472,7 @@ static void f2fs_map_lock(struct f2fs_sb_info *sbi, { f2fs_down_read(&sbi->cp_enable_rwsem); if (flag == F2FS_GET_BLOCK_PRE_AIO) - f2fs_down_read(&sbi->node_change); + f2fs_down_read_trace(&sbi->node_change, lc); else f2fs_lock_op(sbi, lc); } @@ -1482,7 +1482,7 @@ static void f2fs_map_unlock(struct f2fs_sb_info *sbi, int flag) { if (flag == F2FS_GET_BLOCK_PRE_AIO) - f2fs_up_read(&sbi->node_change); + f2fs_up_read_trace(&sbi->node_change, lc); else f2fs_unlock_op(sbi, lc); f2fs_up_read(&sbi->cp_enable_rwsem); diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 03f5eb7549a6..972cff745e63 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -176,6 +176,7 @@ enum device_allocation_policy { enum f2fs_lock_name { LOCK_NAME_NONE, LOCK_NAME_CP_RWSEM, + LOCK_NAME_NODE_CHANGE, }; /* diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index d60b91292c23..0d406fc8bc22 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -4897,7 +4897,7 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc) mutex_init(&sbi->writepages); init_f2fs_rwsem(&sbi->cp_global_sem); init_f2fs_rwsem(&sbi->node_write); - init_f2fs_rwsem(&sbi->node_change); + init_f2fs_rwsem_trace(&sbi->node_change, sbi, LOCK_NAME_NODE_CHANGE); spin_lock_init(&sbi->stat_lock); init_f2fs_rwsem_trace(&sbi->cp_rwsem, sbi, LOCK_NAME_CP_RWSEM); init_f2fs_rwsem(&sbi->cp_enable_rwsem); diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h index f4f13ddbe104..d472f47eedec 100644 --- a/include/trace/events/f2fs.h +++ b/include/trace/events/f2fs.h @@ -186,7 +186,8 @@ TRACE_DEFINE_ENUM(CP_PHASE_FINISH_CHECKPOINT); #define show_lock_name(lock) \ __print_symbolic(lock, \ - { LOCK_NAME_CP_RWSEM, "cp_rwsem" }) + { LOCK_NAME_CP_RWSEM, "cp_rwsem" }, \ + { LOCK_NAME_NODE_CHANGE, "node_change" }) struct f2fs_sb_info; struct f2fs_io_info; -- 2.49.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39F7D23D7DC for ; Sun, 4 Jan 2026 02:08:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767492489; cv=none; b=cM5JYX5v+9mHw1d1FLIDYV/iH59x/pxo/6CYnoV9dx4BVE6o2Ne3Ise6vHmxTb1y5QaQEkcm02MJlAHbfca7cfM+HDUeuk2pFiIC1S1mUnjQLfVbPaL2KuRImw6uLmIQILtO4eKZXvbP/Hehb9VjNucgrFr/+mUWONduSYYke5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767492489; c=relaxed/simple; bh=FjxPDkPb0b6ALOwmCLq6MsIiEbneVQ9Q1d4PppU8+tA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fDO1Hrmqz38PyBWSCtYGEtEtGWKXZAX/P/2CApyTnKg7zbS0MmOcbEFeElA6DCpajBECRbXSy5xs+Yf8wNYfKeAImSF0EPJTByEGdXixKrvoonmrNp8Lyh2EXyk8mk8iG2IRXZT/dpAPIKAJSvOfDi2ks6YRsLUHKcHGMTCbIII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AWYRXeih; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AWYRXeih" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CED15C19423; Sun, 4 Jan 2026 02:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767492488; bh=FjxPDkPb0b6ALOwmCLq6MsIiEbneVQ9Q1d4PppU8+tA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AWYRXeih4MO46MPjN3tbVqoxA2sd5j22OppBIBq+AzszC9hYySubS4DQqkybxblC1 HPqf2+L1joIJsijRio2y6QzWSBtV6yzEj4LZL1Cb1mqXH/FNMgCZmw7izV98rwRdhl dpuaE1XLOVvDcwyoH0M95wLXXtGV4uGatT8kqBnzktwUXcKRiXaU98MHkbYHnLN3hR 91UWAxdbvJeEnt2BKYvoIKjHFqnKvJyJQY6s2PW8GWHVrX+W8RlZg76cpTfu7Nv9vN 99buHy8MTNwVEsqhjhDXX1XZwioQzxSErhCEJFi+m4hBuUNcT6wyFza9JhtGPtrWlg SyilBMKlXuyiQ== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH 04/14] f2fs: trace elapsed time for node_change lock Date: Sun, 4 Jan 2026 10:07:19 +0800 Message-ID: <20260104020729.1064529-4-chao@kernel.org> X-Mailer: git-send-email 2.52.0.358.g0dd7633a29-goog In-Reply-To: <20260104020729.1064529-1-chao@kernel.org> References: <20260104020729.1064529-1-chao@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use f2fs_{down,up}_read_trace for node_change to trace lock elapsed time. Signed-off-by: Chao Yu --- fs/f2fs/data.c | 4 ++-- fs/f2fs/f2fs.h | 1 + fs/f2fs/super.c | 2 +- include/trace/events/f2fs.h | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 73fcafbc8191..5469547142e7 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1472,7 +1472,7 @@ static void f2fs_map_lock(struct f2fs_sb_info *sbi, { f2fs_down_read(&sbi->cp_enable_rwsem); if (flag == F2FS_GET_BLOCK_PRE_AIO) - f2fs_down_read(&sbi->node_change); + f2fs_down_read_trace(&sbi->node_change, lc); else f2fs_lock_op(sbi, lc); } @@ -1482,7 +1482,7 @@ static void f2fs_map_unlock(struct f2fs_sb_info *sbi, int flag) { if (flag == F2FS_GET_BLOCK_PRE_AIO) - f2fs_up_read(&sbi->node_change); + f2fs_up_read_trace(&sbi->node_change, lc); else f2fs_unlock_op(sbi, lc); f2fs_up_read(&sbi->cp_enable_rwsem); diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 03f5eb7549a6..972cff745e63 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -176,6 +176,7 @@ enum device_allocation_policy { enum f2fs_lock_name { LOCK_NAME_NONE, LOCK_NAME_CP_RWSEM, + LOCK_NAME_NODE_CHANGE, }; /* diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index d60b91292c23..0d406fc8bc22 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -4897,7 +4897,7 @@ static int f2fs_fill_super(struct super_block *sb, struct fs_context *fc) mutex_init(&sbi->writepages); init_f2fs_rwsem(&sbi->cp_global_sem); init_f2fs_rwsem(&sbi->node_write); - init_f2fs_rwsem(&sbi->node_change); + init_f2fs_rwsem_trace(&sbi->node_change, sbi, LOCK_NAME_NODE_CHANGE); spin_lock_init(&sbi->stat_lock); init_f2fs_rwsem_trace(&sbi->cp_rwsem, sbi, LOCK_NAME_CP_RWSEM); init_f2fs_rwsem(&sbi->cp_enable_rwsem); diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h index f4f13ddbe104..d472f47eedec 100644 --- a/include/trace/events/f2fs.h +++ b/include/trace/events/f2fs.h @@ -186,7 +186,8 @@ TRACE_DEFINE_ENUM(CP_PHASE_FINISH_CHECKPOINT); #define show_lock_name(lock) \ __print_symbolic(lock, \ - { LOCK_NAME_CP_RWSEM, "cp_rwsem" }) + { LOCK_NAME_CP_RWSEM, "cp_rwsem" }, \ + { LOCK_NAME_NODE_CHANGE, "node_change" }) struct f2fs_sb_info; struct f2fs_io_info; -- 2.49.0