From: Al Viro <viro@zeniv.linux.org.uk>
To: Christian Brauner <brauner@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, "Jan Kara" <jack@suse.cz>,
"Jeff Layton" <jlayton@kernel.org>,
"Amir Goldstein" <amir73il@gmail.com>,
"Lennart Poettering" <lennart@poettering.net>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Josef Bacik" <josef@toxicpanda.com>
Subject: Re: [PATCH 3/3] fs: add immutable rootfs
Date: Sun, 4 Jan 2026 07:41:45 +0000 [thread overview]
Message-ID: <20260104074145.GJ1712166@ZenIV> (raw)
In-Reply-To: <20260104072743.GI1712166@ZenIV>
On Sun, Jan 04, 2026 at 07:27:43AM +0000, Al Viro wrote:
> On Fri, Jan 02, 2026 at 03:36:24PM +0100, Christian Brauner wrote:
>
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/* Copyright (c) 2026 Christian Brauner <brauner@kernel.org> */
> > +#include <linux/fs/super_types.h>
> > +#include <linux/fs_context.h>
> > +#include <linux/magic.h>
>
> [snip]
>
> What does it give you compared to an empty ramfs? Or tmpfs, for that
> matter...
>
> Why bother with a separate fs type?
Make that "empty ramfs" and as soon as you've got the mount have
mnt->mnt_root->d_inode->i_flags |= S_IMMUTABLE;
done. No concurrent accesses at that point, no way to clear that
flag for ramfs inodes afterwards and ramfs is always built in...
What am I missing here?
next prev parent reply other threads:[~2026-01-04 7:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 14:36 [PATCH 0/3] fs: add immutable rootfs and support pivot_root() in the initramfs Christian Brauner
2026-01-02 14:36 ` [PATCH 1/3] fs: ensure that internal tmpfs mount gets mount id zero Christian Brauner
2026-01-02 14:36 ` [PATCH 2/3] fs: add init_pivot_root() Christian Brauner
2026-01-02 14:36 ` [PATCH 3/3] fs: add immutable rootfs Christian Brauner
2026-01-04 7:27 ` Al Viro
2026-01-04 7:41 ` Al Viro [this message]
2026-01-06 22:07 ` Christian Brauner
2026-01-06 22:59 ` Al Viro
2026-01-07 10:53 ` Christian Brauner
2026-01-07 2:28 ` Gao Xiang
2026-01-07 2:47 ` Al Viro
2026-01-07 2:55 ` Gao Xiang
2026-01-07 10:52 ` Christian Brauner
2026-01-07 16:33 ` Colin Walters
2026-01-08 11:02 ` Christian Brauner
2026-01-25 20:47 ` Askar Safin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260104074145.GJ1712166@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=lennart@poettering.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.