From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: airoha: Fix schedule while atomic in airoha_ppe_deinit()
Date: Sun, 4 Jan 2026 09:57:48 -0800 [thread overview]
Message-ID: <20260104095748.70107b9b@kernel.org> (raw)
In-Reply-To: <20251223-airoha-fw-ethtool-v1-1-1dbd1568c585@kernel.org>
On Tue, 23 Dec 2025 22:56:44 +0100 Lorenzo Bianconi wrote:
> Rely on rcu_replace_pointer in airoha_ppe_deinit routine in order to fix
> schedule while atomic issue.
The information in the commit message is not sufficient.
What "schedule while atomic issue"?
> - npu = rcu_dereference(eth->npu);
> + mutex_lock(&flow_offload_mutex);
> +
> + npu = rcu_replace_pointer(eth->npu, NULL,
> + lockdep_is_held(&flow_offload_mutex));
> if (npu) {
> npu->ops.ppe_deinit(npu);
> airoha_npu_put(npu);
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-04 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 21:56 [PATCH net] net: airoha: Fix schedule while atomic in airoha_ppe_deinit() Lorenzo Bianconi
2026-01-04 17:57 ` Jakub Kicinski [this message]
2026-01-05 8:33 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260104095748.70107b9b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.