All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Julien Olivain <ju.o@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support
Date: Sun, 4 Jan 2026 17:46:37 +0100	[thread overview]
Message-ID: <20260104174637.3421eaea@windsurf> (raw)
In-Reply-To: <20260104143240.4126891-2-fiona.klute@gmx.de>

Hello Fiona,

On Sun,  4 Jan 2026 15:32:40 +0100
Fiona Klute <fiona.klute@gmx.de> wrote:

> During the build Cython creates C++ source that needs to be
> compiled. The missing dependency did not show in the existing runtime
> test because the Bootlin stable toolchains include C++ support.
> 
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
> ---
>  package/python-memray/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-memray/Config.in b/package/python-memray/Config.in
> index afd0adc901..75f13e8597 100644
> --- a/package/python-memray/Config.in
> +++ b/package/python-memray/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_PYTHON_MEMRAY
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # elfutils
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # elfutils/libdebuginfod
>  	depends on BR2_PACKAGE_LIBUNWIND_ARCH_SUPPORTS
> +	depends on BR2_INSTALL_LIBSTDCPP
>  	select BR2_PACKAGE_ELFUTILS
>  	select BR2_PACKAGE_ELFUTILS_LIBDEBUGINFOD
>  	select BR2_PACKAGE_LIBUNWIND

I realize that the whole package lacks a Config.in comment documenting
the dependencies, could you add it, perhaps as a preparatory commit?

Also, please indicate in the commit log which commit introduced the
issue.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-01-04 16:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-04 14:32 [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Fiona Klute via buildroot
2026-01-04 14:32 ` [Buildroot] [PATCH 2/2] package/python-memray: require toolchain with C++ support Fiona Klute via buildroot
2026-01-04 16:46   ` Thomas Petazzoni via buildroot [this message]
2026-01-05 14:42     ` Fiona Klute via buildroot
2026-01-05 16:05       ` Thomas Petazzoni via buildroot
2026-01-04 16:45 ` [Buildroot] [PATCH 1/2] package/python-rich: add missing dependency on zlib support in Python Thomas Petazzoni via buildroot
2026-01-04 16:54   ` Fiona Klute via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260104174637.3421eaea@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fiona.klute@gmx.de \
    --cc=james.hilliard1@gmail.com \
    --cc=ju.o@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.