* [PATCH v1 0/1] Remove GIC 128 - 136
@ 2026-01-05 3:19 ` Jamin Lin via
0 siblings, 0 replies; 5+ messages in thread
From: Jamin Lin via @ 2026-01-05 3:19 UTC (permalink / raw)
To: Cédric Le Goater, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs,
open list:All patches CC here
Cc: jamin_lin, troy_lee, kane_chen
This patch series is based on legoater/qemu, branch aspeed-next.
https://github.com/legoater/qemu
v1:
1. Remove PSP GIC 128 to 138 for AST2700 A0.
Fix this patch lost to update inpins.
https://patchwork.kernel.org/project/qemu-devel/patch/20250901040808.1454742-4-jamin_lin@aspeedtech.com/
Jamin Lin (1):
hw/intc/aspeed: Remove GIC 128 - 136
hw/arm/aspeed_ast27x0.c | 17 -----------------
hw/intc/aspeed_intc.c | 2 +-
2 files changed, 1 insertion(+), 18 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v1 0/1] Remove GIC 128 - 136 @ 2026-01-05 3:19 ` Jamin Lin via 0 siblings, 0 replies; 5+ messages in thread From: Jamin Lin via @ 2026-01-05 3:19 UTC (permalink / raw) To: Cédric Le Goater, Peter Maydell, Steven Lee, Troy Lee, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: jamin_lin, troy_lee, kane_chen This patch series is based on legoater/qemu, branch aspeed-next. https://github.com/legoater/qemu v1: 1. Remove PSP GIC 128 to 138 for AST2700 A0. Fix this patch lost to update inpins. https://patchwork.kernel.org/project/qemu-devel/patch/20250901040808.1454742-4-jamin_lin@aspeedtech.com/ Jamin Lin (1): hw/intc/aspeed: Remove GIC 128 - 136 hw/arm/aspeed_ast27x0.c | 17 ----------------- hw/intc/aspeed_intc.c | 2 +- 2 files changed, 1 insertion(+), 18 deletions(-) -- 2.43.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1 1/1] hw/intc/aspeed: Remove GIC 128 - 136 2026-01-05 3:19 ` Jamin Lin via @ 2026-01-05 3:19 ` Jamin Lin via -1 siblings, 0 replies; 5+ messages in thread From: Jamin Lin via @ 2026-01-05 3:19 UTC (permalink / raw) To: Cédric Le Goater, Peter Maydell, Steven Lee, Troy Lee, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: jamin_lin, troy_lee, kane_chen The GIC interrupts 128 - 136 were only used by the AST2700 A0 SoC. Since the AST2700 A0 has been deprecated, these interrupt definitions are no longer needed. This commit removes them to clean up the codebase. Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- hw/arm/aspeed_ast27x0.c | 17 ----------------- hw/intc/aspeed_intc.c | 2 +- 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 52e509afd5..d17f446661 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -207,7 +207,6 @@ static const int ast2700_gic197_intcmap[] = { [ASPEED_DEV_PECI] = 4, }; -/* GICINT 128 ~ 136 */ /* GICINT 192 ~ 201 */ struct gic_intc_irq_info { int irq; @@ -227,15 +226,6 @@ static const struct gic_intc_irq_info ast2700_gic_intcmap[] = { {199, 1, 7, NULL}, {200, 1, 8, NULL}, {201, 1, 9, NULL}, - {128, 0, 1, ast2700_gic192_intcmap}, - {129, 0, 2, NULL}, - {130, 0, 3, ast2700_gic194_intcmap}, - {131, 0, 4, ast2700_gic195_intcmap}, - {132, 0, 5, ast2700_gic196_intcmap}, - {133, 0, 6, ast2700_gic197_intcmap}, - {134, 0, 7, NULL}, - {135, 0, 8, NULL}, - {136, 0, 9, NULL}, }; static qemu_irq aspeed_soc_ast2700_get_irq(AspeedSoCState *s, int dev) @@ -893,13 +883,6 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp) /* * The AST2700 I2C controller has one source INTC per bus. * - * For AST2700 A0: - * I2C bus interrupts are connected to the OR gate from bit 0 to bit - * 15, and the OR gate output pin is connected to the input pin of - * GICINT130 of INTC (CPU Die). Then, the output pin is connected to - * the GIC. - * - * For AST2700 A1: * I2C bus interrupts are connected to the OR gate from bit 0 to bit * 15, and the OR gate output pin is connected to the input pin of * GICINT194 of INTCIO (IO Die). Then, the output pin is connected diff --git a/hw/intc/aspeed_intc.c b/hw/intc/aspeed_intc.c index 1702cb87dc..77fae39205 100644 --- a/hw/intc/aspeed_intc.c +++ b/hw/intc/aspeed_intc.c @@ -778,7 +778,7 @@ static void aspeed_2700_intc_class_init(ObjectClass *klass, const void *data) dc->desc = "ASPEED 2700 INTC Controller"; aic->num_lines = 32; - aic->num_inpins = 10; + aic->num_inpins = 1; aic->num_outpins = 10; aic->mem_size = 0x4000; aic->nr_regs = 0xB08 >> 2; -- 2.43.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v1 1/1] hw/intc/aspeed: Remove GIC 128 - 136 @ 2026-01-05 3:19 ` Jamin Lin via 0 siblings, 0 replies; 5+ messages in thread From: Jamin Lin via @ 2026-01-05 3:19 UTC (permalink / raw) To: Cédric Le Goater, Peter Maydell, Steven Lee, Troy Lee, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: jamin_lin, troy_lee, kane_chen The GIC interrupts 128 - 136 were only used by the AST2700 A0 SoC. Since the AST2700 A0 has been deprecated, these interrupt definitions are no longer needed. This commit removes them to clean up the codebase. Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- hw/arm/aspeed_ast27x0.c | 17 ----------------- hw/intc/aspeed_intc.c | 2 +- 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 52e509afd5..d17f446661 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -207,7 +207,6 @@ static const int ast2700_gic197_intcmap[] = { [ASPEED_DEV_PECI] = 4, }; -/* GICINT 128 ~ 136 */ /* GICINT 192 ~ 201 */ struct gic_intc_irq_info { int irq; @@ -227,15 +226,6 @@ static const struct gic_intc_irq_info ast2700_gic_intcmap[] = { {199, 1, 7, NULL}, {200, 1, 8, NULL}, {201, 1, 9, NULL}, - {128, 0, 1, ast2700_gic192_intcmap}, - {129, 0, 2, NULL}, - {130, 0, 3, ast2700_gic194_intcmap}, - {131, 0, 4, ast2700_gic195_intcmap}, - {132, 0, 5, ast2700_gic196_intcmap}, - {133, 0, 6, ast2700_gic197_intcmap}, - {134, 0, 7, NULL}, - {135, 0, 8, NULL}, - {136, 0, 9, NULL}, }; static qemu_irq aspeed_soc_ast2700_get_irq(AspeedSoCState *s, int dev) @@ -893,13 +883,6 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp) /* * The AST2700 I2C controller has one source INTC per bus. * - * For AST2700 A0: - * I2C bus interrupts are connected to the OR gate from bit 0 to bit - * 15, and the OR gate output pin is connected to the input pin of - * GICINT130 of INTC (CPU Die). Then, the output pin is connected to - * the GIC. - * - * For AST2700 A1: * I2C bus interrupts are connected to the OR gate from bit 0 to bit * 15, and the OR gate output pin is connected to the input pin of * GICINT194 of INTCIO (IO Die). Then, the output pin is connected diff --git a/hw/intc/aspeed_intc.c b/hw/intc/aspeed_intc.c index 1702cb87dc..77fae39205 100644 --- a/hw/intc/aspeed_intc.c +++ b/hw/intc/aspeed_intc.c @@ -778,7 +778,7 @@ static void aspeed_2700_intc_class_init(ObjectClass *klass, const void *data) dc->desc = "ASPEED 2700 INTC Controller"; aic->num_lines = 32; - aic->num_inpins = 10; + aic->num_inpins = 1; aic->num_outpins = 10; aic->mem_size = 0x4000; aic->nr_regs = 0xB08 >> 2; -- 2.43.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 0/1] Remove GIC 128 - 136 2026-01-05 3:19 ` Jamin Lin via (?) (?) @ 2026-01-05 9:41 ` Cédric Le Goater -1 siblings, 0 replies; 5+ messages in thread From: Cédric Le Goater @ 2026-01-05 9:41 UTC (permalink / raw) To: Jamin Lin, Peter Maydell, Steven Lee, Troy Lee, Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs, open list:All patches CC here Cc: troy_lee, kane_chen Hello Jamin, On 1/5/26 04:19, Jamin Lin wrote: > This patch series is based on legoater/qemu, branch aspeed-next. > https://github.com/legoater/qemu > > v1: > 1. Remove PSP GIC 128 to 138 for AST2700 A0. > Fix this patch lost to update inpins. > https://patchwork.kernel.org/project/qemu-devel/patch/20250901040808.1454742-4-jamin_lin@aspeedtech.com/ I have merged this patch in : https://patchwork.kernel.org/project/qemu-devel/patch/20250901040808.1454742-4-jamin_lin@aspeedtech.com/ and pushed in branch aspeed-next. Thanks, C. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-01-05 9:42 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-01-05 3:19 [PATCH v1 0/1] Remove GIC 128 - 136 Jamin Lin via 2026-01-05 3:19 ` Jamin Lin via 2026-01-05 3:19 ` [PATCH v1 1/1] hw/intc/aspeed: " Jamin Lin via 2026-01-05 3:19 ` Jamin Lin via 2026-01-05 9:41 ` [PATCH v1 0/1] " Cédric Le Goater
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.