From: Matthew Schwartz <matthew.schwartz@linux.dev>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Ricky Wu <ricky_wu@realtek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Schwartz <matthew.schwartz@linux.dev>
Subject: [PATCH 2/2] mmc: rtsx_pci_sdmmc: increase power-on settling delay to 5ms
Date: Sun, 4 Jan 2026 22:02:36 -0800 [thread overview]
Message-ID: <20260105060236.400366-3-matthew.schwartz@linux.dev> (raw)
In-Reply-To: <20260105060236.400366-1-matthew.schwartz@linux.dev>
The existing 1ms delay in sd_power_on is insufficient and causes resume
errors around 4% of the time.
Increasing the delay to 5ms resolves this issue after testing 300
s2idle cycles.
Fixes: 1f311c94aabd ("mmc: rtsx: add 74 Clocks in power on flow")
Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
---
drivers/mmc/host/rtsx_pci_sdmmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
index 74ee8623ad4e..9e95c6000256 100644
--- a/drivers/mmc/host/rtsx_pci_sdmmc.c
+++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
@@ -947,7 +947,7 @@ static int sd_power_on(struct realtek_pci_sdmmc *host, unsigned char power_mode)
if (err < 0)
return err;
- mdelay(1);
+ mdelay(5);
err = rtsx_pci_write_register(pcr, CARD_OE, SD_OUTPUT_EN, SD_OUTPUT_EN);
if (err < 0)
--
2.52.0
next prev parent reply other threads:[~2026-01-05 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 6:02 [PATCH 0/2] mmc: rtsx: card stuck busy fixes for Realtek PCI SD card readers Matthew Schwartz
2026-01-05 6:02 ` [PATCH 1/2] mmc: rtsx: reset power state on suspend Matthew Schwartz
2026-01-20 12:41 ` Ulf Hansson
2026-01-20 18:38 ` Matthew Schwartz
2026-01-21 10:16 ` Ulf Hansson
2026-01-05 6:02 ` Matthew Schwartz [this message]
2026-01-21 10:13 ` [PATCH 0/2] mmc: rtsx: card stuck busy fixes for Realtek PCI SD card readers Ulf Hansson
2026-01-21 10:31 ` Greg Kroah-Hartman
2026-01-21 12:49 ` Ulf Hansson
2026-01-21 14:51 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105060236.400366-3-matthew.schwartz@linux.dev \
--to=matthew.schwartz@linux.dev \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.