From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: mkl@pengutronix.de, Prithvi <activprithvi@gmail.com>,
andrii@kernel.org, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
netdev@vger.kernel.org
Subject: Re: [bpf, xdp] headroom - was: Re: Question about to KMSAN: uninit-value in can_receive
Date: Mon, 5 Jan 2026 15:26:38 -0800 [thread overview]
Message-ID: <20260105152638.74cfea6c@kernel.org> (raw)
In-Reply-To: <fac5da75-2fc0-464c-be90-34220313af64@hartkopp.net>
On Mon, 5 Jan 2026 14:47:08 +0100 Oliver Hartkopp wrote:
> For the ifindex I would propose to store it in struct skb_shared_info:
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 86737076101d..f7233b8f461c 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -604,10 +604,15 @@ struct skb_shared_info {
> struct xsk_tx_metadata_compl xsk_meta;
> };
> unsigned int gso_type;
> u32 tskey;
>
> +#if IS_ENABLED(CONFIG_CAN)
> + /* initial CAN iif to avoid routing back to it (can-gw) */
> + int can_iif;
> +#endif
> +
> /*
> * Warning : all fields before dataref are cleared in __alloc_skb()
> */
> atomic_t dataref;
>
> Would this be a suitable approach to get rid of struct can_skb_priv in
> your opinion?
Possibly a naive question but why is skb_iif not working here?
next prev parent reply other threads:[~2026-01-05 23:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 13:36 [syzbot] [can?] KMSAN: uninit-value in can_receive (3) syzbot
2025-11-17 17:30 ` Question about to KMSAN: uninit-value in can_receive Prithvi Tambewagh
2025-11-29 17:04 ` Oliver Hartkopp
2025-11-30 12:04 ` Feedback provided on question about " Prithvi Tambewagh
2025-11-30 12:44 ` Question about to " Oliver Hartkopp
2025-11-30 17:29 ` Prithvi Tambewagh
2025-11-30 19:09 ` Oliver Hartkopp
2025-12-07 18:45 ` Prithvi
2025-12-20 17:33 ` Prithvi
2025-12-21 18:29 ` [bpf, xdp] headroom - was: " Oliver Hartkopp
2025-12-21 19:06 ` Marc Kleine-Budde
2025-12-21 19:42 ` Oliver Hartkopp
2026-01-02 15:36 ` Prithvi
2026-01-02 20:04 ` Jakub Kicinski
2026-01-03 12:20 ` Oliver Hartkopp
2026-01-04 15:42 ` Jakub Kicinski
2026-01-05 13:47 ` Oliver Hartkopp
2026-01-05 23:26 ` Jakub Kicinski [this message]
2026-01-06 12:04 ` Oliver Hartkopp
2026-01-07 0:23 ` Jakub Kicinski
2026-01-07 15:34 ` Oliver Hartkopp
2026-01-07 19:10 ` Oliver Hartkopp
2026-01-08 15:17 ` Jakub Kicinski
2026-01-08 16:27 ` Oliver Hartkopp
2026-01-05 21:30 ` Andrii Nakryiko
2026-01-05 22:11 ` Daniel Borkmann
2025-11-28 17:48 ` Feedback on question about " Prithvi Tambewagh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105152638.74cfea6c@kernel.org \
--to=kuba@kernel.org \
--cc=activprithvi@gmail.com \
--cc=andrii@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.