From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC23432C333 for ; Tue, 6 Jan 2026 14:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710811; cv=none; b=IZXVu6sAeSeHTLwsFDl6eDNob0Rqpq+Us1S9HCBmFYboW6yWh9l6m6hK/H1mBbXz/6fr4qscsqpKIUrRjaGBhpgzCNFBDlXgpcQXNLnAhpjVE0DvY3R4hSNke9FPj2uge+CwXa6Gf8l56jauHqoA56tsF/84yOkUoy/Sq86g4Dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767710811; c=relaxed/simple; bh=lW5s9q7Wm15e2YhMbfyoEedNcv4OWH7pmG4QV536gyk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=obPthH4kdFKy9nA4fZ+DVabv6Wv3aV7q7ndfcezhsWijGFqGqhPGMUtUk18ucw4J6NEUWSEQTll6tOucGhTBhD/H0QUUWFPUKwYGZmTITeHucV1zRUX+7AQu/Z5ITyJHLuIbXvXXsKsyHhg2C06jv3AI5AYMF1Y6t8oKACzifyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=emdrG9GA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="emdrG9GA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB1B8C116C6; Tue, 6 Jan 2026 14:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1767710811; bh=lW5s9q7Wm15e2YhMbfyoEedNcv4OWH7pmG4QV536gyk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=emdrG9GAnOyour5eC70UK/4F6pQg/8fpifm7BR/MvyqmrMUIqpUanAKW6TnLdzO67 cm/bixmIYg9TLCFjWt0Ila9bC8M2nmWVVtmqF+ZAnSLkzPF54+WWgCwGV2HNuZbijo al5nY13eum0plQ9DmTSndlEWttZ5f4+mNNVCxSYI= Date: Tue, 6 Jan 2026 15:46:48 +0100 From: Greg Kroah-Hartman To: "Usyskin, Alexander" Cc: "Abliyev, Reuven" , "linux-kernel@vger.kernel.org" Subject: Re: [char-misc] mei: trace: treat reg parameter as string Message-ID: <2026010603-wing-widget-232e@gregkh> References: <20260104082044.3977688-1-alexander.usyskin@intel.com> <2026010632-brewing-grandpa-96de@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 06, 2026 at 10:59:26AM +0000, Usyskin, Alexander wrote: > > Subject: Re: [char-misc] mei: trace: treat reg parameter as string > > > > On Sun, Jan 04, 2026 at 10:20:44AM +0200, Alexander Usyskin wrote: > > > Process the reg string parameter in secure way. > > > > > > > I'm sorry, but I don't understand this changelog text. What exactly is > > this doing? Why is a string "better" than a char *? > > > > thanks, > > > > greg k-h > > Sorry, I'm bad in changelogs, trying to improve... It is usually the hardest part of making a code change. > The string wrapper checks sanity of parameters and prevents internal kernel data leaks. > Newer kernels refuse to emit event with plain char*, without the wrapper. > See https://elixir.bootlin.com/linux/v6.19-rc3/source/kernel/trace/trace.c#L3785 Great, please take this information and rewrite this to explain the need here and what this change is doing. thanks, greg k-h