All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: drivers/accel/amdxdna/aie2_ctx.c:783:11-15: ERROR: invalid reference to the index variable of the iterator on line 771
Date: Tue, 06 Jan 2026 12:13:00 +0800	[thread overview]
Message-ID: <202601061241.AVIVEWiP-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Lizhi Hou <lizhi.hou@amd.com>
CC: Jeff Hugo <jeff.hugo@oss.qualcomm.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7f98ab9da046865d57c102fd3ca9669a29845f67
commit: e486147c912f653ef4b60a6c7dbd4168a4c56a9f accel/amdxdna: Add BO import and export
date:   9 months ago
:::::: branch date: 6 hours ago
:::::: commit date: 9 months ago
config: x86_64-randconfig-104-20260106 (https://download.01.org/0day-ci/archive/20260106/202601061241.AVIVEWiP-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202601061241.AVIVEWiP-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/accel/amdxdna/aie2_ctx.c:783:11-15: ERROR: invalid reference to the index variable of the iterator on line 771

vim +783 drivers/accel/amdxdna/aie2_ctx.c

aac243092b707bb Lizhi Hou 2024-11-18  757  
aac243092b707bb Lizhi Hou 2024-11-18  758  static int aie2_populate_range(struct amdxdna_gem_obj *abo)
aac243092b707bb Lizhi Hou 2024-11-18  759  {
aac243092b707bb Lizhi Hou 2024-11-18  760  	struct amdxdna_dev *xdna = to_xdna_dev(to_gobj(abo)->dev);
e486147c912f653 Lizhi Hou 2025-03-25  761  	struct amdxdna_umap *mapp;
aac243092b707bb Lizhi Hou 2024-11-18  762  	unsigned long timeout;
e486147c912f653 Lizhi Hou 2025-03-25  763  	struct mm_struct *mm;
e486147c912f653 Lizhi Hou 2025-03-25  764  	bool found;
aac243092b707bb Lizhi Hou 2024-11-18  765  	int ret;
aac243092b707bb Lizhi Hou 2024-11-18  766  
e486147c912f653 Lizhi Hou 2025-03-25  767  	timeout = jiffies + msecs_to_jiffies(HMM_RANGE_DEFAULT_TIMEOUT);
e486147c912f653 Lizhi Hou 2025-03-25  768  again:
e486147c912f653 Lizhi Hou 2025-03-25  769  	found = false;
e486147c912f653 Lizhi Hou 2025-03-25  770  	down_write(&xdna->notifier_lock);
e486147c912f653 Lizhi Hou 2025-03-25 @771  	list_for_each_entry(mapp, &abo->mem.umap_list, node) {
e486147c912f653 Lizhi Hou 2025-03-25  772  		if (mapp->invalid) {
e486147c912f653 Lizhi Hou 2025-03-25  773  			found = true;
e486147c912f653 Lizhi Hou 2025-03-25  774  			break;
e486147c912f653 Lizhi Hou 2025-03-25  775  		}
e486147c912f653 Lizhi Hou 2025-03-25  776  	}
aac243092b707bb Lizhi Hou 2024-11-18  777  
e486147c912f653 Lizhi Hou 2025-03-25  778  	if (!found) {
e486147c912f653 Lizhi Hou 2025-03-25  779  		abo->mem.map_invalid = false;
e486147c912f653 Lizhi Hou 2025-03-25  780  		up_write(&xdna->notifier_lock);
e486147c912f653 Lizhi Hou 2025-03-25  781  		return 0;
e486147c912f653 Lizhi Hou 2025-03-25  782  	}
e486147c912f653 Lizhi Hou 2025-03-25 @783  	kref_get(&mapp->refcnt);
e486147c912f653 Lizhi Hou 2025-03-25  784  	up_write(&xdna->notifier_lock);
e486147c912f653 Lizhi Hou 2025-03-25  785  
e486147c912f653 Lizhi Hou 2025-03-25  786  	XDNA_DBG(xdna, "populate memory range %lx %lx",
e486147c912f653 Lizhi Hou 2025-03-25  787  		 mapp->vma->vm_start, mapp->vma->vm_end);
e486147c912f653 Lizhi Hou 2025-03-25  788  	mm = mapp->notifier.mm;
e486147c912f653 Lizhi Hou 2025-03-25  789  	if (!mmget_not_zero(mm)) {
e486147c912f653 Lizhi Hou 2025-03-25  790  		amdxdna_umap_put(mapp);
aac243092b707bb Lizhi Hou 2024-11-18  791  		return -EFAULT;
e486147c912f653 Lizhi Hou 2025-03-25  792  	}
aac243092b707bb Lizhi Hou 2024-11-18  793  
e486147c912f653 Lizhi Hou 2025-03-25  794  	mapp->range.notifier_seq = mmu_interval_read_begin(&mapp->notifier);
aac243092b707bb Lizhi Hou 2024-11-18  795  	mmap_read_lock(mm);
e486147c912f653 Lizhi Hou 2025-03-25  796  	ret = hmm_range_fault(&mapp->range);
aac243092b707bb Lizhi Hou 2024-11-18  797  	mmap_read_unlock(mm);
aac243092b707bb Lizhi Hou 2024-11-18  798  	if (ret) {
aac243092b707bb Lizhi Hou 2024-11-18  799  		if (time_after(jiffies, timeout)) {
aac243092b707bb Lizhi Hou 2024-11-18  800  			ret = -ETIME;
aac243092b707bb Lizhi Hou 2024-11-18  801  			goto put_mm;
aac243092b707bb Lizhi Hou 2024-11-18  802  		}
aac243092b707bb Lizhi Hou 2024-11-18  803  
e486147c912f653 Lizhi Hou 2025-03-25  804  		if (ret == -EBUSY) {
e486147c912f653 Lizhi Hou 2025-03-25  805  			amdxdna_umap_put(mapp);
aac243092b707bb Lizhi Hou 2024-11-18  806  			goto again;
e486147c912f653 Lizhi Hou 2025-03-25  807  		}
aac243092b707bb Lizhi Hou 2024-11-18  808  
aac243092b707bb Lizhi Hou 2024-11-18  809  		goto put_mm;
aac243092b707bb Lizhi Hou 2024-11-18  810  	}
aac243092b707bb Lizhi Hou 2024-11-18  811  
e486147c912f653 Lizhi Hou 2025-03-25  812  	down_write(&xdna->notifier_lock);
e486147c912f653 Lizhi Hou 2025-03-25  813  	if (mmu_interval_read_retry(&mapp->notifier, mapp->range.notifier_seq)) {
e486147c912f653 Lizhi Hou 2025-03-25  814  		up_write(&xdna->notifier_lock);
e486147c912f653 Lizhi Hou 2025-03-25  815  		amdxdna_umap_put(mapp);
aac243092b707bb Lizhi Hou 2024-11-18  816  		goto again;
aac243092b707bb Lizhi Hou 2024-11-18  817  	}
e486147c912f653 Lizhi Hou 2025-03-25  818  	mapp->invalid = false;
e486147c912f653 Lizhi Hou 2025-03-25  819  	up_write(&xdna->notifier_lock);
e486147c912f653 Lizhi Hou 2025-03-25  820  	amdxdna_umap_put(mapp);
e486147c912f653 Lizhi Hou 2025-03-25  821  	goto again;
aac243092b707bb Lizhi Hou 2024-11-18  822  
aac243092b707bb Lizhi Hou 2024-11-18  823  put_mm:
e486147c912f653 Lizhi Hou 2025-03-25  824  	amdxdna_umap_put(mapp);
aac243092b707bb Lizhi Hou 2024-11-18  825  	mmput(mm);
aac243092b707bb Lizhi Hou 2024-11-18  826  	return ret;
aac243092b707bb Lizhi Hou 2024-11-18  827  }
aac243092b707bb Lizhi Hou 2024-11-18  828  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2026-01-06  4:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06  4:13 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-02-12 21:19 drivers/accel/amdxdna/aie2_ctx.c:783:11-15: ERROR: invalid reference to the index variable of the iterator on line 771 kernel test robot
2026-03-17 10:09 kernel test robot
2026-05-05  5:00 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202601061241.AVIVEWiP-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.