Re: [Buildroot] [V2] package/k3conf: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Mohammed Sadik Shaik via buildroot <buildroot@buildroot.org>
Cc: Mohammed Sadik Shaik <s-sadik@ti.com>, Bryan Brattlof <bb@ti.com>,
	"Bajjuri Praneeth" <praneeth@ti.com>
Subject: Re: [Buildroot] [V2] package/k3conf: new package
Date: Tue, 6 Jan 2026 22:00:23 +0100	[thread overview]
Message-ID: <20260106220023.5441033a@windsurf> (raw)
In-Reply-To: <20251218065017.1286139-1-s-sadik@ti.com>

Hello Mohammed,

On Thu, 18 Dec 2025 12:20:18 +0530
Mohammed Sadik Shaik via buildroot <buildroot@buildroot.org> wrote:

> K3CONF is a Linux user-space standalone application
> designed to provide a quick'n easy way to dynamically
> diagnose Texas Instruments' K3 architecture based
> processors. K3CONF is intended to provide similar
> experience to that of OMAPCONF that runs on legacy TI platforms.
> 
> K3CONF currently supports Texas Instruments AM654, J721E, J7200, 
> AM64x,AM62x,J721S2,J784S4,J722S, AM62Ax, AM62Px, and AM62Lx devices.
> Along with the BeagleBoard variants of the above mentioned TI SOC's.
> 
> Signed-off-by: Mohammed Sadik Shaik <s-sadik@ti.com>

Thanks for your v2, which I have applied with some tweaks. See below.

> diff --git a/package/k3conf/Config.in b/package/k3conf/Config.in
> new file mode 100644
> index 0000000000..6146a5413b
> --- /dev/null
> +++ b/package/k3conf/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_K3CONF
> +	bool "k3conf"

Added:

	depends no BR2_aarch64

here since it's only for K3 platforms, which AFAIK are all ARM64.

> +	help
> +	  A Powerful Diagnostic Tool for Texas Instruments K3 based
> +	  Processors.

Replaced this text with parts of your commit log, which was much more
useful.

Added a blank line to separate the help text with the upstream URL
below.

> +	  https://git.ti.com/cgit/k3conf/k3conf
> diff --git a/package/k3conf/k3conf.hash b/package/k3conf/k3conf.hash
> new file mode 100644
> index 0000000000..2c8d4ef664
> --- /dev/null
> +++ b/package/k3conf/k3conf.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated sha256sum
> +sha256  a3459f80e7af5672da6b41bc0814114690dd549aac4cf81ba4e5dc84d42ab9c6  k3conf-v0.4-git4.tar.gz
> +sha256  f962a0a4912aeae2d6f2f6e07bc3f79f7f1df9d4bf1abfb5c421b9b14352bfaf  LICENSE
> diff --git a/package/k3conf/k3conf.mk b/package/k3conf/k3conf.mk
> new file mode 100644
> index 0000000000..da21fcccbb
> --- /dev/null
> +++ b/package/k3conf/k3conf.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# k3conf
> +#
> +################################################################################
> +
> +K3CONF_VERSION = v0.4
> +K3CONF_SITE = https://git.ti.com/git/k3conf/k3conf.git
> +K3CONF_SITE_METHOD = git
> +K3CONF_LICENSE = BSD-3-Clause
> +K3CONF_LICENSE_FILES = LICENSE
> +
> +define K3CONF_LINUX_CONFIG_FIXUPS
> +        $(call KCONFIG_ENABLE_OPT,CONFIG_DEVMEM)

Indentation here should have been with a tab. Noticed by "make
check-package".

Thanks a lot for your contribution!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot