All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Jie Zhan <zhanjie9@hisilicon.com>
Cc: ardb@kernel.org, dhowells@redhat.com,
	linux-kernel@vger.kernel.org, linuxarm@huawei.com,
	jonathan.cameron@huawei.com, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: tests: Fix syntax error for old python versions
Date: Tue, 6 Jan 2026 19:43:41 -0800	[thread overview]
Message-ID: <20260107034341.GB2283@sol> (raw)
In-Reply-To: <20260107033018.GA2283@sol>

On Tue, Jan 06, 2026 at 07:30:19PM -0800, Eric Biggers wrote:
> On Wed, Jan 07, 2026 at 09:58:29AM +0800, Jie Zhan wrote:
> > 'make binrpm-pkg' throws me this error, with Python 3.9:
> > 
> > *** Error compiling '.../gen-hash-testvecs.py'...
> >   File ".../scripts/crypto/gen-hash-testvecs.py", line 121
> >     return f'{alg.upper().replace('-', '_')}_DIGEST_SIZE'
> >                                    ^
> > SyntaxError: f-string: unmatched '('
> > 
> > Old python versions, presumably <= 3.11, can't resolve these quotes.
> > 
> > Fix it with double quotes for compatibility.
> > 
> > Fixes: 15c64c47e484 ("lib/crypto: tests: Add SHA3 kunit tests")
> > Signed-off-by: Jie Zhan <zhanjie9@hisilicon.com>
> > ---
> >  scripts/crypto/gen-hash-testvecs.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> I'll apply this, but it's weird that 'make binrpm-pkg' is doing anything
> with this script.  It's not executed during the kernel build process.
> It's only run manually to generate some files that are checked in
> elsewhere in the tree.
> 
> - Eric

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-fixes

- Eric

      reply	other threads:[~2026-01-07  3:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  1:58 [PATCH] lib/crypto: tests: Fix syntax error for old python versions Jie Zhan
2026-01-07  3:30 ` Eric Biggers
2026-01-07  3:43   ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260107034341.GB2283@sol \
    --to=ebiggers@kernel.org \
    --cc=ardb@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=zhanjie9@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.