All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/crypto: tests: polyval_kunit: Increase iterations for preparekey in IRQs
Date: Tue, 6 Jan 2026 20:06:48 -0800	[thread overview]
Message-ID: <20260107040648.GD2283@sol> (raw)
In-Reply-To: <20260105092043-d18628ec-a42a-490b-8bbf-d611dd5afb5a@linutronix.de>

On Mon, Jan 05, 2026 at 09:21:32AM +0100, Thomas Weißschuh wrote:
> On Fri, Jan 02, 2026 at 10:27:48AM -0800, Eric Biggers wrote:
> > On Fri, Jan 02, 2026 at 08:32:03AM +0100, Thomas Weißschuh wrote:
> > > On my development machine the generic, memcpy()-only implementation of
> > > polyval_preparekey() is too fast for the IRQ workers to actually fire.
> > > The test fails.
> > > 
> > > Increase the iterations to make the test more robust.
> > > The test will run for a maximum of one second in any case.
> > > 
> > > Fixes: b3aed551b3fc ("lib/crypto: tests: Add KUnit tests for POLYVAL")
> > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > 
> > Glad to see that people are running these tests!  I actually already
> > applied
> > https://lore.kernel.org/linux-crypto/20251219085259.1163048-1-davidgow@google.com/
> > for this issue, which should be sufficient by itself.
> 
> That works, too. Thanks!
> 
> > Might be worth
> > increasing the iteration count as well, but I'd like to check whether
> > any other tests could use a similar change as well.
> 
> No other one of the default tests failed for me in a similar way.
> 
> 
> Thomas

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-fixes

I added the following note to the commit message:

   [EB: This failure was already fixed by commit c31f4aa8fed0 ("kunit:
    Enforce task execution in {soft,hard}irq contexts").  I'm still applying
    this patch too, since the iteration count in this test made its running
    time much shorter than the other similar ones.]

- Eric

  reply	other threads:[~2026-01-07  4:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-02  7:32 [PATCH] lib/crypto: tests: polyval_kunit: Increase iterations for preparekey in IRQs Thomas Weißschuh
2026-01-02 18:27 ` Eric Biggers
2026-01-05  8:21   ` Thomas Weißschuh
2026-01-07  4:06     ` Eric Biggers [this message]
2026-01-06 11:53   ` David Gow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260107040648.GD2283@sol \
    --to=ebiggers@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.