From: Bin Guo <guobin@linux.alibaba.com>
To: berrange@redhat.com
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, philmd@linaro.org
Subject: Re: Re: [PATCH] monitor: disable "info kvm" if !KVM
Date: Wed, 7 Jan 2026 17:40:20 +0800 [thread overview]
Message-ID: <20260107094020.21819-1-guobin@linux.alibaba.com> (raw)
In-Reply-To: <aVuUXHT9dt9-ytkG@redhat.com>
Daniel P. Berrangé wrote on Mon, 5 Jan 2026 10:37:16 +0000:
> Missing commit message explaining why we should do this ?
The reason for submitting this patch is that the newly supported
'info accelerators' command can provide a more comprehensive view
of the accelerator's status.
>
> The 'hmp_info_kvm' implementation is unconditionally built and this patch
> isn't changing that, so this result in building unused code.
>
> Conceptually even if KVM is not built, it makes sense to have an
> 'info kvm' command to tell the user that KVM is not available.
I agree with you, we can skip this patch.
With regards,
Bin Guo
next prev parent reply other threads:[~2026-01-07 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 3:43 [PATCH] monitor: disable "info kvm" if !KVM Bin Guo
2026-01-05 10:37 ` Daniel P. Berrangé
2026-01-07 9:40 ` Bin Guo [this message]
2026-01-08 7:57 ` Markus Armbruster
2026-01-08 9:46 ` Daniel P. Berrangé
2026-01-08 11:35 ` Markus Armbruster
2026-01-08 11:38 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107094020.21819-1-guobin@linux.alibaba.com \
--to=guobin@linux.alibaba.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.