All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ionut Nechita (Sunlight Linux)" <sunlightlinux@gmail.com>
To: jikos@kernel.org, bentiss@kernel.org
Cc: superm1@kernel.org, benato.denis96@gmail.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	ionut_n2001@yahoo.com, sunlightlinux@gmail.com
Subject: [PATCH v2 0/4] HID: asus: Filter HID codes and add WMI fan control for ROG laptops
Date: Wed,  7 Jan 2026 13:19:42 +0200	[thread overview]
Message-ID: <20260107111945.48018-2-sunlightlinux@gmail.com> (raw)
In-Reply-To: <10abfaa7-9f5b-494c-8bb5-5da53c087fc4@kernel.org>

From: Ionut Nechita <ionut_n2001@yahoo.com>

Hi Mario and maintainers,

Thank you for the review feedback on v1. I've addressed all the issues:

Changes in v2:
- Split the monolithic patch into 4 logical patches as requested
- Fixed include order (linux/acpi.h now before linux/dmi.h)
- Added #define ASUS_FAN_CTRL_KEY_CODE for 0xae instead of magic number
- Added #defines for the filtered spurious codes as well for clarity

The patch series now:
1. Replaces magic number with existing HID_UP_ASUSVENDOR constant
2. Filters spurious HID vendor codes (with proper #defines)
3. Adds WMI communication infrastructure
4. Implements Fn+F5 fan control key handler (using #define)

This eliminates kernel log spam from unmapped HID codes and enables
proper fan control functionality on Asus ROG G14/G15 laptops.

Tested on Asus ROG G14/G15 series laptops.

Ionut Nechita (4):
  HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant
  HID: asus: Filter spurious HID vendor codes on ROG laptops
  HID: asus: Add WMI communication infrastructure
  HID: asus: Implement Fn+F5 fan control key handler

 drivers/hid/hid-asus.c                     | 60 +++++++++++++++++++++-
 include/linux/platform_data/x86/asus-wmi.h |  1 +
 2 files changed, 60 insertions(+), 1 deletion(-)

-- 
2.52.0


  reply	other threads:[~2026-01-07 11:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 14:04 [PATCH 0/1] HID: asus: Add ROG laptop HID code filtering and fan control Ionut Nechita (Sunlight Linux)
2026-01-06 14:04 ` [PATCH] HID: asus: Filter HID vendor codes and add WMI fan control support for ROG laptops Ionut Nechita (Sunlight Linux)
2026-01-06 16:18   ` Mario Limonciello (AMD) (kernel.org)
2026-01-07 11:19     ` Ionut Nechita (Sunlight Linux) [this message]
2026-01-07 11:19       ` [PATCH 1/4] HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant Ionut Nechita (Sunlight Linux)
2026-01-07 13:00         ` Denis Benato
2026-01-07 15:13           ` Mario Limonciello
2026-01-07 11:19       ` [PATCH 2/4] HID: asus: Filter spurious HID vendor codes on ROG laptops Ionut Nechita (Sunlight Linux)
2026-01-07 13:02         ` Denis Benato
2026-01-07 15:12         ` Mario Limonciello
2026-01-07 11:19       ` [PATCH 3/4] HID: asus: Add WMI communication infrastructure Ionut Nechita (Sunlight Linux)
2026-01-07 13:07         ` Denis Benato
2026-01-07 15:14           ` Mario Limonciello
2026-01-07 15:20             ` Denis Benato
2026-01-07 11:19       ` [PATCH 4/4] HID: asus: Implement Fn+F5 fan control key handler Ionut Nechita (Sunlight Linux)
2026-01-07 13:10         ` Denis Benato
2026-01-07 13:00       ` [PATCH v2 0/4] HID: asus: Filter HID codes and add WMI fan control for ROG laptops Denis Benato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260107111945.48018-2-sunlightlinux@gmail.com \
    --to=sunlightlinux@gmail.com \
    --cc=benato.denis96@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=ionut_n2001@yahoo.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=superm1@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.