All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain via buildroot <buildroot@buildroot.org>
Cc: Julien Olivain <ju.o@free.fr>,
	Alexander Shirokov <shirokovalexs@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] support/testing: add aichat runtime test
Date: Wed, 7 Jan 2026 15:07:25 +0100	[thread overview]
Message-ID: <20260107150725.10c0fba7@windsurf> (raw)
In-Reply-To: <20260106231110.991548-1-ju.o@free.fr>

Hello Julien,

Thanks for the patch! Obviously looks good, just one question.

On Wed,  7 Jan 2026 00:11:10 +0100
Julien Olivain via buildroot <buildroot@buildroot.org> wrote:

> +    def test_run(self):
> +        self.login()
> +
> +        # Check the program can execute.
> +        self.assertRunOk("aichat --version")
> +
> +        # We define a Hugging Face model to be downloaded.
> +        # We choose a relatively small model, for testing.
> +        hf_model = "ggml-org/gemma-3-270m-it-GGUF"

Does this mean that the model will be downloaded by llama-server when
we run it? I don't think we expect tests to require a network
connection to the Internet, and download "random stuff".

Or did I misunderstand your comment?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-01-07 14:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 23:11 [Buildroot] [PATCH 1/1] support/testing: add aichat runtime test Julien Olivain via buildroot
2026-01-07  8:50 ` Alexander Shirokov
2026-01-07 14:07 ` Thomas Petazzoni via buildroot [this message]
2026-01-07 18:20   ` Julien Olivain via buildroot
2026-02-03  8:29     ` Julien Olivain via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260107150725.10c0fba7@windsurf \
    --to=buildroot@buildroot.org \
    --cc=ju.o@free.fr \
    --cc=shirokovalexs@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.