From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A654838BF9F for ; Wed, 7 Jan 2026 15:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767801456; cv=none; b=NKvm4QSrc8Lc+yPBaq55Cl72l92ns3T5c7eYW4YBTAhHlpwjMtredzjvOjervlpQbU6U7L49fAR49Mt9EAtAf2YstqCpG+ICVjNxBHn28S1Vc4eY7NTHY6v/lkBTGxnvTv0IOZp/dAInqcj/k2xYt1Vf6QpQ5AdxvjneqzUeZ/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767801456; c=relaxed/simple; bh=DhY/D275TXFgMi4+MzvJcAdFNU59ETRlS5STN5M/d7Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nt1YtpEvYKVeXbkdJCHHb5d2QZTC5iMMmC4dNDnJeSOq6W1Me7FZRhsEYuxDYiidIuMnNbO8aZwP+JW4/7MLmIW/n2KrXQeXDZclQ8ZK2LGEEFzT5tcjNGGTLPtP5ZJYVuK0IU4nFCQTKL9ol/YXJOceui7tGBTtl+6Aetz0oHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XingjCUr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XingjCUr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D7DAC19422; Wed, 7 Jan 2026 15:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767801455; bh=DhY/D275TXFgMi4+MzvJcAdFNU59ETRlS5STN5M/d7Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XingjCUr67DVP5geOtXZkiv8MKNqPofQqrZ8FvQp5EvIEGfr66cAPDJ6g+dku43Cm BdvblHNDjufQ1ACDhEfd0KhtVaOJEI2ejZhDLiVo7xR7wAJ0BkoGjk1supYX4LQ6KV Cc8pfq0j850sZmKLvbbXCqHMiDPUj6xUbnBOJC96O+SWO68m3PInMFqPI96sB0kn48 taCF4lFXqwNdEjkplkzqMrN8YvG62zoUFGtiMSAwvh/7rOdoW30AyYk/9i1bMVwXqp uWEdAxIS3ZWpW0EiMXTL+9IVi+ZNkO+DEuiR+5Wt9Bn2MuaAkEVbLBLUfODjyXFOSS Dcdy3ixRuPfyw== From: Sasha Levin To: stable@vger.kernel.org Cc: Thomas Zimmermann , Patrik Jakobsson , Stefan Christ , Daniel Vetter , dri-devel@lists.freedesktop.org, Sasha Levin Subject: [PATCH 5.15.y] drm/gma500: Remove unused helper psb_fbdev_fb_setcolreg() Date: Wed, 7 Jan 2026 10:57:33 -0500 Message-ID: <20260107155733.4065165-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2026010530-sitcom-outdated-cc0f@gregkh> References: <2026010530-sitcom-outdated-cc0f@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Thomas Zimmermann [ Upstream commit be729f9de6c64240645dc80a24162ac4d3fe00a8 ] Remove psb_fbdev_fb_setcolreg(), which hasn't been called in almost a decade. Gma500 commit 4d8d096e9ae8 ("gma500: introduce the framebuffer support code") added the helper psb_fbdev_fb_setcolreg() for setting the fbdev palette via fbdev's fb_setcolreg callback. Later commit 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops") set several default helpers for fbdev emulation, including fb_setcmap. The fbdev subsystem always prefers fb_setcmap over fb_setcolreg. [1] Hence, the gma500 code is no longer in use and gma500 has been using drm_fb_helper_setcmap() for several years without issues. Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops") Cc: Patrik Jakobsson Cc: Stefan Christ Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: # v4.10+ Link: https://elixir.bootlin.com/linux/v6.16.9/source/drivers/video/fbdev/core/fbcmap.c#L246 # [1] Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250929082338.18845-1-tzimmermann@suse.de [ adapted patch from fbdev.c to framebuffer.c where the function was named psbfb_setcolreg() instead of psb_fbdev_fb_setcolreg() ] Signed-off-by: Sasha Levin --- drivers/gpu/drm/gma500/framebuffer.c | 42 ---------------------------- 1 file changed, 42 deletions(-) diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c index 0b8648396fb2..060771910374 100644 --- a/drivers/gpu/drm/gma500/framebuffer.c +++ b/drivers/gpu/drm/gma500/framebuffer.c @@ -35,47 +35,6 @@ static const struct drm_framebuffer_funcs psb_fb_funcs = { .create_handle = drm_gem_fb_create_handle, }; -#define CMAP_TOHW(_val, _width) ((((_val) << (_width)) + 0x7FFF - (_val)) >> 16) - -static int psbfb_setcolreg(unsigned regno, unsigned red, unsigned green, - unsigned blue, unsigned transp, - struct fb_info *info) -{ - struct drm_fb_helper *fb_helper = info->par; - struct drm_framebuffer *fb = fb_helper->fb; - uint32_t v; - - if (!fb) - return -ENOMEM; - - if (regno > 255) - return 1; - - red = CMAP_TOHW(red, info->var.red.length); - blue = CMAP_TOHW(blue, info->var.blue.length); - green = CMAP_TOHW(green, info->var.green.length); - transp = CMAP_TOHW(transp, info->var.transp.length); - - v = (red << info->var.red.offset) | - (green << info->var.green.offset) | - (blue << info->var.blue.offset) | - (transp << info->var.transp.offset); - - if (regno < 16) { - switch (fb->format->cpp[0] * 8) { - case 16: - ((uint32_t *) info->pseudo_palette)[regno] = v; - break; - case 24: - case 32: - ((uint32_t *) info->pseudo_palette)[regno] = v; - break; - } - } - - return 0; -} - static vm_fault_t psbfb_vm_fault(struct vm_fault *vmf) { struct vm_area_struct *vma = vmf->vma; @@ -147,7 +106,6 @@ static int psbfb_mmap(struct fb_info *info, struct vm_area_struct *vma) static const struct fb_ops psbfb_unaccel_ops = { .owner = THIS_MODULE, DRM_FB_HELPER_DEFAULT_OPS, - .fb_setcolreg = psbfb_setcolreg, .fb_fillrect = drm_fb_helper_cfb_fillrect, .fb_copyarea = drm_fb_helper_cfb_copyarea, .fb_imageblit = drm_fb_helper_cfb_imageblit, -- 2.51.0