Re: [Buildroot] [PATCH v1 1/1] package/python-ncclient: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Vincent,

On Wed,  7 Jan 2026 19:01:08 +0100
Vincent Jardin via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/package/python-ncclient/Config.in b/package/python-ncclient/Config.in
> new file mode 100644
> index 0000000000..2be69efb2b
> --- /dev/null
> +++ b/package/python-ncclient/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_PYTHON_NCCLIENT
> +	bool "python-ncclient"
> +	depends on BR2_PACKAGE_PYTHON3

Not needed.

> +	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS # python-paramiko
> +	select BR2_PACKAGE_PYTHON_LXML
> +	select BR2_PACKAGE_PYTHON_PARAMIKO
> +	select BR2_PACKAGE_PYTHON_SIX
> +	help
> +	  ncclient is a Python library for NETCONF clients. It
> +	  facilitates client-side scripting and application
> +	  development around NETCONF.
> +
> +	  https://github.com/ncclient/ncclient
> +
> +comment "python-ncclient needs python3 and host Rust (for paramiko)"
> +	depends on !BR2_PACKAGE_PYTHON3 || !BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS

Not needed. BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS is an
architecture dependency, so we don't write a comment about it, since
there's nothing the user can do about it.

> diff --git a/package/python-ncclient/python-ncclient.mk b/package/python-ncclient/python-ncclient.mk
> new file mode 100644
> index 0000000000..ca1b23e441
> --- /dev/null
> +++ b/package/python-ncclient/python-ncclient.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# python-ncclient
> +#
> +################################################################################
> +
> +PYTHON_NCCLIENT_VERSION = 0.7.0
> +PYTHON_NCCLIENT_SOURCE = ncclient-$(PYTHON_NCCLIENT_VERSION).tar.gz
> +PYTHON_NCCLIENT_SITE = https://files.pythonhosted.org/packages/source/n/ncclient
> +
> +PYTHON_NCCLIENT_LICENSE = Apache-2.0
> +PYTHON_NCCLIENT_LICENSE_FILES = LICENSE
> +
> +PYTHON_NCCLIENT_SETUP_TYPE = setuptools
> +
> +PYTHON_NCCLIENT_DEPENDENCIES = \
> +	python-lxml \
> +	python-paramiko \
> +	python-six

Are you sure these are build-time dependencies? Most of the time Python
modules are only run-time dependencies.

And as asked for some other patches, a test case in support/testing/
would be nice.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot