All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "Abliyev, Reuven" <reuven.abliyev@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [char-misc v2] mei: trace: treat reg parameter as string
Date: Thu, 8 Jan 2026 09:17:12 +0100	[thread overview]
Message-ID: <2026010801-lard-maximum-7bc3@gregkh> (raw)
In-Reply-To: <CY5PR11MB6366F18F00C57AFB8C1E71CDED85A@CY5PR11MB6366.namprd11.prod.outlook.com>

On Thu, Jan 08, 2026 at 07:59:08AM +0000, Usyskin, Alexander wrote:
> > Subject: Re: [char-misc v2] mei: trace: treat reg parameter as string
> > 
> > On Thu, Jan 08, 2026 at 07:42:22AM +0000, Usyskin, Alexander wrote:
> > > > Subject: Re: [char-misc v2] mei: trace: treat reg parameter as string
> > > >
> > > > On Thu, Jan 08, 2026 at 08:57:02AM +0200, Alexander Usyskin wrote:
> > > > > Use the string wrapper to check sanity of the reg parameters,
> > > > > store it value independently and prevent internal kernel data leaks.
> > > > > Trace subsystem refuses to emit event with plain char*,
> > > > > without the wrapper.
> > > > >
> > > > > Cc: stable@vger.kernel.org
> > > >
> > > > Does this really fix a bug?  If not, there's no need for cc: stable or:
> > > >
> > > > > Fixes: a0a927d06d79 ("mei: me: add io register tracing")
> > > >
> > > > That line as well.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > Without this patch the events are not emitted at all, they are dropped
> > > by trace security checker.
> > 
> > Ah, again, that was not obvious at all from the changelog.  Perhaps
> > reword it a bit?  How has this ever worked?
> > 
> 
> This security hardening was introduced way after the initial commit
> and the breakage went unnoticed for some time, unfortunately.

So then the "Fixes:" tag is not correct :(

  reply	other threads:[~2026-01-08  8:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08  6:57 [char-misc v2] mei: trace: treat reg parameter as string Alexander Usyskin
2026-01-08  7:40 ` Greg Kroah-Hartman
2026-01-08  7:42   ` Usyskin, Alexander
2026-01-08  7:55     ` Greg Kroah-Hartman
2026-01-08  7:59       ` Usyskin, Alexander
2026-01-08  8:17         ` Greg Kroah-Hartman [this message]
2026-01-08  8:18           ` Greg Kroah-Hartman
2026-01-08 12:35             ` Usyskin, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026010801-lard-maximum-7bc3@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.usyskin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reuven.abliyev@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.