From: kernel test robot <lkp@intel.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: oe-kbuild-all@lists.linux.dev, Petr Machata <petrm@nvidia.com>
Subject: [jpirko-mlxsw:combined_queue 10/10] drivers/tty/serial/xilinx_uartps.c:438:25: sparse: sparse: dereference of noderef expression
Date: Thu, 08 Jan 2026 02:20:48 +0800 [thread overview]
Message-ID: <202601080205.PiFUdOjj-lkp@intel.com> (raw)
tree: https://github.com/jpirko/linux_mlxsw combined_queue
head: 2dc192c6a328240368616b0f08864c8e7a35abb6
commit: 1c79063b436b437afd074eb39f2374b27ac91aa2 [10/10] TMP: Revert "module: Add compile-time check for embedded NUL characters"
config: nios2-randconfig-r132-20260107 (https://download.01.org/0day-ci/archive/20260108/202601080205.PiFUdOjj-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260108/202601080205.PiFUdOjj-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601080205.PiFUdOjj-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/tty/serial/xilinx_uartps.c:438:25: sparse: sparse: dereference of noderef expression
vim +438 drivers/tty/serial/xilinx_uartps.c
fccc9d9233f918 Manikanta Guntupalli 2024-01-23 418
74231ab6cc2d02 Manikanta Guntupalli 2024-01-23 419 /**
74231ab6cc2d02 Manikanta Guntupalli 2024-01-23 420 * cdns_uart_handle_tx - Handle the bytes to be transmitted.
c8dbdc842d3061 Anirudha Sarangi 2016-09-22 421 * @dev_id: Id of the UART port
c8dbdc842d3061 Anirudha Sarangi 2016-09-22 422 * Return: None
c8dbdc842d3061 Anirudha Sarangi 2016-09-22 423 */
c8dbdc842d3061 Anirudha Sarangi 2016-09-22 424 static void cdns_uart_handle_tx(void *dev_id)
07986580d0ad14 Soren Brinkmann 2016-01-11 425 {
c8dbdc842d3061 Anirudha Sarangi 2016-09-22 426 struct uart_port *port = (struct uart_port *)dev_id;
fccc9d9233f918 Manikanta Guntupalli 2024-01-23 427 struct cdns_uart *cdns_uart = port->private_data;
1788cf6a91d9fa Jiri Slaby (SUSE 2024-04-05 428) struct tty_port *tport = &port->state->port;
07986580d0ad14 Soren Brinkmann 2016-01-11 429 unsigned int numbytes;
1788cf6a91d9fa Jiri Slaby (SUSE 2024-04-05 430) unsigned char ch;
267ee93c417e68 j.turek 2025-12-21 431 ktime_t rts_delay;
07986580d0ad14 Soren Brinkmann 2016-01-11 432
1788cf6a91d9fa Jiri Slaby (SUSE 2024-04-05 433) if (kfifo_is_empty(&tport->xmit_fifo) || uart_tx_stopped(port)) {
74231ab6cc2d02 Manikanta Guntupalli 2024-01-23 434 /* Disable the TX Empty interrupt */
07986580d0ad14 Soren Brinkmann 2016-01-11 435 writel(CDNS_UART_IXR_TXEMPTY, port->membase + CDNS_UART_IDR);
267ee93c417e68 j.turek 2025-12-21 436 /* Set RTS line after delay */
267ee93c417e68 j.turek 2025-12-21 437 if (cdns_uart->port->rs485.flags & SER_RS485_ENABLED) {
267ee93c417e68 j.turek 2025-12-21 @438 cdns_uart->tx_timer.function = &cdns_rs485_rx_callback;
267ee93c417e68 j.turek 2025-12-21 439 rts_delay = ns_to_ktime(cdns_calc_after_tx_delay(cdns_uart));
267ee93c417e68 j.turek 2025-12-21 440 hrtimer_start(&cdns_uart->tx_timer, rts_delay, HRTIMER_MODE_REL);
267ee93c417e68 j.turek 2025-12-21 441 }
a28ef75816fcce Jiri Slaby 2022-04-21 442 return;
a28ef75816fcce Jiri Slaby 2022-04-21 443 }
a28ef75816fcce Jiri Slaby 2022-04-21 444
07986580d0ad14 Soren Brinkmann 2016-01-11 445 numbytes = port->fifosize;
1788cf6a91d9fa Jiri Slaby (SUSE 2024-04-05 446) while (numbytes &&
1788cf6a91d9fa Jiri Slaby (SUSE 2024-04-05 447) !(readl(port->membase + CDNS_UART_SR) & CDNS_UART_SR_TXFULL) &&
1788cf6a91d9fa Jiri Slaby (SUSE 2024-04-05 448) uart_fifo_get(port, &ch)) {
1788cf6a91d9fa Jiri Slaby (SUSE 2024-04-05 449) writel(ch, port->membase + CDNS_UART_FIFO);
07986580d0ad14 Soren Brinkmann 2016-01-11 450 numbytes--;
07986580d0ad14 Soren Brinkmann 2016-01-11 451 }
07986580d0ad14 Soren Brinkmann 2016-01-11 452
1788cf6a91d9fa Jiri Slaby (SUSE 2024-04-05 453) if (kfifo_len(&tport->xmit_fifo) < WAKEUP_CHARS)
07986580d0ad14 Soren Brinkmann 2016-01-11 454 uart_write_wakeup(port);
fccc9d9233f918 Manikanta Guntupalli 2024-01-23 455
fccc9d9233f918 Manikanta Guntupalli 2024-01-23 456 /* Enable the TX Empty interrupt */
fccc9d9233f918 Manikanta Guntupalli 2024-01-23 457 writel(CDNS_UART_IXR_TXEMPTY, cdns_uart->port->membase + CDNS_UART_IER);
07986580d0ad14 Soren Brinkmann 2016-01-11 458 }
07986580d0ad14 Soren Brinkmann 2016-01-11 459
:::::: The code at line 438 was first introduced by commit
:::::: 267ee93c417e685d9f8e079e41c70ba6ee4df5a5 serial: xilinx_uartps: fix rs485 delay_rts_after_send
:::::: TO: j.turek <jakub.turek@elsta.tech>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-01-07 18:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202601080205.PiFUdOjj-lkp@intel.com \
--to=lkp@intel.com \
--cc=idosch@nvidia.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.