All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 11/11] xfs: add media error reporting ioctl
Date: Thu, 8 Jan 2026 11:25:59 +0100	[thread overview]
Message-ID: <20260108102559.GA25394@lst.de> (raw)
In-Reply-To: <20260107163035.GA15551@frogsfrogsfrogs>

On Wed, Jan 07, 2026 at 08:30:35AM -0800, Darrick J. Wong wrote:
> > FYI, I'd much prefer adding the kernel support than relying in userspace
> > doing it, which will be hard to move away from.
> 
> Hrm.  I wonder, does the block layer use iomap for directio?  Now that
> the fserror reporting has been hooked up to iomap, I wonder if it's
> possible for xfs_healer to listen for file IO errors on a block device?
> 
> Oh.  block/fops.c doesn't actually call iomap_dio_* so I guess that's
> not yet possible.  Would it be easier to convert blockdevs to use iomap,
> or should I bite the bullet and convert the legacy direct_IO code?

The block code basically has it's own simplified copy of the iomap
direct I/O code.

> Or I guess one of us should go figure out a reasonable verify command
> that would call fserror_* on media errors.

Hmm, I would expect the verify command to be issued by fs/xfs/scrub/
in the kernel, so that it can be directly tied into the in-kernel
logical to physical and rmap.  But you are more well versed there,
so maybe I'm missing something.


  reply	other threads:[~2026-01-08 10:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06  7:10 [PATCHSET V4] xfs: autonomous self healing of filesystems Darrick J. Wong
2026-01-06  7:10 ` [PATCH 01/11] docs: discuss autonomous self healing in the xfs online repair design doc Darrick J. Wong
2026-01-07  9:08   ` Christoph Hellwig
2026-01-07 19:15     ` Darrick J. Wong
2026-01-06  7:11 ` [PATCH 02/11] xfs: start creating infrastructure for health monitoring Darrick J. Wong
2026-01-07  9:17   ` Christoph Hellwig
2026-01-07 18:50     ` Darrick J. Wong
2026-01-08 10:21       ` Christoph Hellwig
2026-01-06  7:11 ` [PATCH 03/11] xfs: create event queuing, formatting, and discovery infrastructure Darrick J. Wong
2026-01-07  9:32   ` Christoph Hellwig
2026-01-07 19:01     ` Darrick J. Wong
2026-01-06  7:11 ` [PATCH 04/11] xfs: convey filesystem unmount events to the health monitor Darrick J. Wong
2026-01-06  7:11 ` [PATCH 05/11] xfs: convey metadata health " Darrick J. Wong
2026-01-06  7:12 ` [PATCH 06/11] xfs: convey filesystem shutdown " Darrick J. Wong
2026-01-06  7:12 ` [PATCH 07/11] xfs: convey externally discovered fsdax media errors " Darrick J. Wong
2026-01-06  7:12 ` [PATCH 08/11] xfs: convey file I/O " Darrick J. Wong
2026-01-06  7:12 ` [PATCH 09/11] xfs: allow reconfiguration of the health monitoring device Darrick J. Wong
2026-01-06  7:13 ` [PATCH 10/11] xfs: check if an open file is on the health monitored fs Darrick J. Wong
2026-01-06  7:13 ` [PATCH 11/11] xfs: add media error reporting ioctl Darrick J. Wong
2026-01-07  9:36   ` Christoph Hellwig
2026-01-07 16:30     ` Darrick J. Wong
2026-01-08 10:25       ` Christoph Hellwig [this message]
2026-01-08 16:09         ` Darrick J. Wong
2026-01-08 16:14           ` Christoph Hellwig
2026-01-08 16:18             ` Darrick J. Wong
2026-01-08 16:20               ` Christoph Hellwig
2026-01-08 16:53                 ` Darrick J. Wong
2026-01-12  5:24                   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108102559.GA25394@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.