From: Jakub Kicinski <kuba@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol@kernel.org>
Subject: Re: [RFC can-next 2/5] can: move can_iif from private headroom to struct sk_buff
Date: Thu, 8 Jan 2026 12:25:16 -0800 [thread overview]
Message-ID: <20260108122516.221e9bc0@kernel.org> (raw)
In-Reply-To: <20260108160716.101883-2-socketcan@hartkopp.net>
On Thu, 8 Jan 2026 17:07:13 +0100 Oliver Hartkopp wrote:
> union {
> - __be16 inner_protocol;
> - __u8 inner_ipproto;
> - };
> + /* protocols with encapsulation */
> + struct {
> + union {
> + __be16 inner_protocol;
> + __u8 inner_ipproto;
> + };
>
> - __u16 inner_transport_header;
> - __u16 inner_network_header;
> - __u16 inner_mac_header;
> + __u16 inner_transport_header;
> + __u16 inner_network_header;
> + __u16 inner_mac_header;
> + };
> + /* protocols without encapsulation */
> + struct {
> + int can_iif;
> + };
> + };
I won't accept this patch but it's a matter of taste so maybe you can
convince another of the netdev maintainers to take this.
next prev parent reply other threads:[~2026-01-08 20:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 16:07 [RFC can-next 1/5] can: use skb hash instead of private variable in headroom Oliver Hartkopp
2026-01-08 16:07 ` [RFC can-next 2/5] can: move can_iif from private headroom to struct sk_buff Oliver Hartkopp
2026-01-08 20:25 ` Jakub Kicinski [this message]
2026-01-08 21:24 ` Oliver Hartkopp
2026-01-08 16:07 ` [RFC can-next 3/5] can: move frame length " Oliver Hartkopp
2026-01-08 16:07 ` [RFC can-next 4/5] can: remove private skb headroom infrastructure Oliver Hartkopp
2026-01-08 16:07 ` [RFC can-next 5/5] can: gw: use new maxhops variable instead of re-using csum_start Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108122516.221e9bc0@kernel.org \
--to=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.