From: Jon Hunter <jonathanh@nvidia.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, "Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: <linux-sound@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH 2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect
Date: Thu, 8 Jan 2026 14:31:57 +0000 [thread overview]
Message-ID: <20260108143158.351223-3-jonathanh@nvidia.com> (raw)
In-Reply-To: <20260108143158.351223-1-jonathanh@nvidia.com>
The device-tree property 'realtek,jack-detect-source' currently only
permits values from 0-6. However, commit 2b9c8d2b3c89 ("ASoC: rt5640:
Add the HDA header support") updated the Realtek rt5640 to support
setting the 'realtek,jack-detect-source' to 7 to support the HDA header.
The Tegra234 platforms currently set 'realtek,jack-detect-source' to 7
for the HDA header and this is causing a warning when building
device-tree.
audio-codec@1c (realtek,rt5640): realtek,jack-detect-source:
7 is not one of [0, 1, 2, 3, 4, 5, 6]
Given that the driver already supports this settings, update the binding
document for the rt5640 device to add the HDA header as a valid
configuration for the 'realtek,jack-detect-source' property.
Fixes: 2b9c8d2b3c89 ("ASoC: rt5640: Add the HDA header support")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
Documentation/devicetree/bindings/sound/realtek,rt5640.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
index 6bb6e12bdf8b..e7d4ec29b0ec 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5640.yaml
@@ -106,6 +106,7 @@ properties:
- 4 # Use GPIO2 for jack-detect
- 5 # Use GPIO3 for jack-detect
- 6 # Use GPIO4 for jack-detect
+ - 7 # Use HDA header for jack-detect
realtek,jack-detect-not-inverted:
description:
--
2.43.0
next prev parent reply other threads:[~2026-01-08 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 14:31 [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes Jon Hunter
2026-01-08 14:31 ` [PATCH 1/3] ASoC: dt-bindings: realtek,rt5640: Document mclk Jon Hunter
2026-01-09 8:50 ` Krzysztof Kozlowski
2026-01-08 14:31 ` Jon Hunter [this message]
2026-01-09 8:54 ` [PATCH 2/3] ASoC: dt-bindings: realtek,rt5640: Update jack-detect Krzysztof Kozlowski
2026-01-08 14:31 ` [PATCH 3/3] ASoC: dt-bindings: realtek,rt5640: Document port node Jon Hunter
2026-01-09 8:55 ` Krzysztof Kozlowski
2026-01-13 17:51 ` [PATCH 0/3] ASoC: dt-bindings: realtek,rt5640: Various fixes Mark Brown
2026-01-14 11:27 ` Jon Hunter
2026-01-14 12:03 ` Mark Brown
2026-01-14 22:06 ` Mark Brown
2026-01-17 0:58 ` Thierry Reding
2026-01-21 1:35 ` Rob Herring
2026-01-22 12:21 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108143158.351223-3-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.