From: Jason Gunthorpe <jgg@nvidia.com>
To: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Joerg Roedel <joerg.roedel@amd.com>,
Kevin Tian <kevin.tian@intel.com>,
kernel test robot <lkp@intel.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
patches@lists.linux.dev, Samiullah Khawaja <skhawaja@google.com>
Subject: Re: [PATCH rc 1/3] iommupt: Fix the kunit building
Date: Thu, 8 Jan 2026 10:49:02 -0400 [thread overview]
Message-ID: <20260108144902.GD23056@nvidia.com> (raw)
In-Reply-To: <81de8774-535e-407e-8b01-5676c2cfd204@oracle.com>
On Thu, Jan 08, 2026 at 09:37:17AM -0500, Alejandro Jimenez wrote:
> > diff --git a/drivers/iommu/generic_pt/.kunitconfig b/drivers/iommu/generic_pt/.kunitconfig
> > index 52ac9e661ffd2b..a78b295f264d23 100644
> > --- a/drivers/iommu/generic_pt/.kunitconfig
> > +++ b/drivers/iommu/generic_pt/.kunitconfig
> > @@ -1,4 +1,5 @@
> > CONFIG_KUNIT=y
> > +CONFIG_COMPILE_TEST=y
>
> I was wondering if there are any side effects from enabling COMPILE_TEST. I
> see that Geert had the same question on:
On it's own COMPILE_TEST isn't supposed to make any functional
changes, just enable more drivers.
IMHO the .kunitconfig fragments are really only for direct use by the
kunit.py, if some distro wanted to enable kunits on top of a
production kernel they should not just blindly import the
.kunitconfigs into the .config..
> and that you agreed with his proposed approach to do:
>
> menuconfig GENERIC_PT
> - bool "Generic Radix Page Table" if COMPILE_TEST
> + bool "Generic Radix Page Table" if COMPILE_TEST || KUNIT
>
> (which also works as long as CONFIG_IOMMUFD_TEST=y is removed).
> Is there a problem with making GENERIC_PT visible on KUNIT=y?
Ah, I may have forgot about this, I don't have a strong opinion either
way.
Jason
next prev parent reply other threads:[~2026-01-08 14:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 19:22 [PATCH rc 0/3] Fix some kconfig related issues with iommu pt Jason Gunthorpe
2026-01-06 19:22 ` [PATCH rc 1/3] iommupt: Fix the kunit building Jason Gunthorpe
2026-01-08 14:37 ` Alejandro Jimenez
2026-01-08 14:49 ` Jason Gunthorpe [this message]
2026-01-09 18:23 ` Alejandro Jimenez
2026-01-06 19:22 ` [PATCH rc 2/3] iommufd/selftest: Add missing kconfig for DMA_SHARED_BUFFER Jason Gunthorpe
2026-01-06 19:22 ` [PATCH rc 3/3] iommufd/selftest: Prevent module/builtin conflicts in kconfig Jason Gunthorpe
2026-01-10 9:41 ` [PATCH rc 0/3] Fix some kconfig related issues with iommu pt Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108144902.GD23056@nvidia.com \
--to=jgg@nvidia.com \
--cc=alejandro.j.jimenez@oracle.com \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=iommu@lists.linux.dev \
--cc=joerg.roedel@amd.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=lkp@intel.com \
--cc=nicolinc@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=skhawaja@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.