All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Scott Mitchell <scott.k.mitch1@gmail.com>
Cc: dev@dpdk.org, mb@smartsharesystems.com
Subject: Re: [PATCH v5] net: optimize raw checksum computation
Date: Thu, 8 Jan 2026 16:00:58 -0800	[thread overview]
Message-ID: <20260108160058.685cf7a7@phoenix.local> (raw)
In-Reply-To: <CAFn2buDp4ffHuSXmTrW8mfNHxm-t3FL=TVgMKFAc2gU7fyXPGg@mail.gmail.com>

On Thu, 8 Jan 2026 16:19:37 -0500
Scott Mitchell <scott.k.mitch1@gmail.com> wrote:

> On Thu, Jan 8, 2026 at 11:12 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Thu,  8 Jan 2026 01:13:38 -0500
> > scott.k.mitch1@gmail.com wrote:
> >  
> > > +#ifdef RTE_CC_GCC
> > > +     /* Suppress GCC -Wmaybe-uninitialized false positive. No assembly/runtime impacts. */
> > > +     asm volatile("" : "+m" (psd_hdr));
> > > +#endif
> > >  
> >
> > Maybe rte_compiler_barrier() will do same thing?  
> 
> Agreed it feels like a compiler bug but looking for advice if I'm
> missing something :)
> 
> My initial concern with rte_compiler_barrier is its a general barrier
> which may have broader impacts on
> optimizations and compiled code. Will that be an issue in this case? I
> wasn't sure and the approach
> in the patch is targeted at a specific variable and assembly from
> clang/gcc was the same. I will
> introduce a macro to make it cleaner and I can replace it with
> rte_compiler_barrier if preferred.

Maybe try with -fanalyzer and it might tell you more.
I suspect some of the aliasing setting are causing issues.
Some drivers are turning on no-strict-aliasing




  reply	other threads:[~2026-01-09  0:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08  6:13 [PATCH v5] net: optimize raw checksum computation scott.k.mitch1
2026-01-08 16:10 ` Stephen Hemminger
2026-01-08 16:12 ` Stephen Hemminger
2026-01-08 21:19   ` Scott Mitchell
2026-01-09  0:00     ` Stephen Hemminger [this message]
2026-01-09  4:57       ` Scott Mitchell
2026-01-09  9:08         ` Morten Brørup
2026-01-09 17:04           ` Scott Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260108160058.685cf7a7@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=scott.k.mitch1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.