All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tiffany Yang <ynaffit@google.com>,
	stable@vger.kernel.org, pchelkin@ispras.ru,
	linux-kernel@vger.kernel.org, kernel-team@android.com,
	Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH 5.10,5.15,6.1,6.6 RESEND] leds: spi-byte: Initialize device node before access
Date: Thu, 8 Jan 2026 12:04:14 +0100	[thread overview]
Message-ID: <2026010849-capricorn-backside-0a6e@gregkh> (raw)
In-Reply-To: <aVe7_7Jf_FWkBhqH@smile.fi.intel.com>

On Fri, Jan 02, 2026 at 02:37:19PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 30, 2025 at 04:45:11PM -0800, Tiffany Yang wrote:
> > Commit 7f9ab862e05c ("leds: spi-byte: Call of_node_put() on error path")
> > was merged in 6.11 and then backported to stable trees through 5.10. It
> > relocates the line that initializes the variable 'child' to a later
> > point in spi_byte_probe().
> > 
> > Versions < 6.9 do not have commit ccc35ff2fd29 ("leds: spi-byte: Use
> > devm_led_classdev_register_ext()"), which removes a line that reads a
> > property from 'child' before its new initialization point. Consequently,
> > spi_byte_probe() reads from an uninitialized device node in stable
> > kernels 6.6-5.10.
> 
> I'm wondering if in long term the easier maintenance will be with that patch
> also being backported rather than this being applied.

I agree, that might be simplest.

thanks,

greg k-h

  reply	other threads:[~2026-01-08 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-31  0:45 [PATCH 5.10,5.15,6.1,6.6 RESEND] leds: spi-byte: Initialize device node before access Tiffany Yang
2026-01-02 12:37 ` Andy Shevchenko
2026-01-08 11:04   ` Greg KH [this message]
2026-01-08 12:03   ` Lee Jones
2026-01-08 22:19     ` Tiffany Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026010849-capricorn-backside-0a6e@gregkh \
    --to=greg@kroah.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=kernel-team@android.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=pchelkin@ispras.ru \
    --cc=stable@vger.kernel.org \
    --cc=ynaffit@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.