From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Anuj Gupta <anuj20.g@samsung.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 3/3] block: use pi_tuple_size in bi_offload_capable()
Date: Fri, 9 Jan 2026 06:53:08 +0100 [thread overview]
Message-ID: <20260109055308.GC4949@lst.de> (raw)
In-Reply-To: <20260108172212.1402119-4-csander@purestorage.com>
On Thu, Jan 08, 2026 at 10:22:12AM -0700, Caleb Sander Mateos wrote:
> bi_offload_capable() returns whether a block device's metadata size
> matches its PI tuple size. Use pi_tuple_size instead of switching on
> csum_type. This makes the code considerably simpler and less branchy.
>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-01-09 5:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 17:22 [PATCH v2 0/3] block: zero non-PI portion of auto integrity buffer Caleb Sander Mateos
2026-01-08 17:22 ` [PATCH v2 1/3] " Caleb Sander Mateos
2026-01-09 5:51 ` Christoph Hellwig
2026-01-08 17:22 ` [PATCH v2 2/3] block: replace gfp_t with bool in bio_integrity_prep() Caleb Sander Mateos
2026-01-08 22:28 ` Anuj gupta
2026-01-09 5:52 ` Christoph Hellwig
2026-01-08 17:22 ` [PATCH v2 3/3] block: use pi_tuple_size in bi_offload_capable() Caleb Sander Mateos
2026-01-08 22:39 ` Anuj gupta
2026-01-09 5:53 ` Christoph Hellwig [this message]
2026-01-08 21:37 ` [PATCH v2 0/3] block: zero non-PI portion of auto integrity buffer Martin K. Petersen
2026-01-09 13:57 ` Jens Axboe
2026-01-09 16:29 ` Caleb Sander Mateos
2026-01-10 17:21 ` Jens Axboe
2026-01-10 17:28 ` Jens Axboe
2026-01-10 20:05 ` Caleb Sander Mateos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109055308.GC4949@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.