From: Jakub Kicinski <kuba@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: fixed_phy: replace list of fixed PHYs with static array
Date: Fri, 9 Jan 2026 08:31:30 -0800 [thread overview]
Message-ID: <20260109083130.50ae4ba9@kernel.org> (raw)
In-Reply-To: <aWEaWvV_0SfylwW5@shell.armlinux.org.uk>
On Fri, 9 Jan 2026 15:10:18 +0000 Russell King (Oracle) wrote:
> > Isn't IDA an overkill for a range this tiny?
> > IDA is useful if the ID range is large and may be sparse.
> > Here a bitmap would suffice.
> >
> > DECLARE_BITMAP(phy_fixed_ids, NUM_FP);
> >
> > id = find_first_zero_bit(phy_fixed_ids, NUM_FP);
> > if (id >= NUM_FP)
> > return -ENOSPC;
> >
> > set_bit(id, phy_fixed_ids);
>
> Racy without locking.
True, if there's no existing locking wrap it in a do {} while and use
test_and_set_bit() as the condition for repeat.
prev parent reply other threads:[~2026-01-09 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 16:56 [PATCH net-next] net: phy: fixed_phy: replace list of fixed PHYs with static array Heiner Kallweit
2026-01-06 17:51 ` Russell King (Oracle)
2026-01-09 2:11 ` Jakub Kicinski
2026-01-09 11:00 ` Heiner Kallweit
2026-01-09 14:43 ` Jakub Kicinski
2026-01-09 15:10 ` Russell King (Oracle)
2026-01-09 16:31 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260109083130.50ae4ba9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.