From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 821FF310771 for ; Fri, 9 Jan 2026 15:41:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767973303; cv=none; b=JiSPKL11v5OooVttiPV6V7L7C+gRiIysZnIgeksQfKfeF3plfTTXDmeytLs85SESkOd0BVYKnOkwVgIDoD/cwVgdur44NGFQZ2dAWeeSVCH2OhbRKyLvim6ekdHsirTlwGOdDS/TYZmf4I3oOdfBykZCHgMFZFblx2FxAm1I5VE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767973303; c=relaxed/simple; bh=0wcHDgSpLs2pCXUqhBdUziVISHn2lfYudCfXokz2QnY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hygwHtouVZonyJ6CLyYHUPM8yCSuzI/9jGNi0BfkLJocxD8I7XtiP0ievALlyxdD+/O1QFTx696+7XdwGTuD0csqfKh5sSQPjPCuJL+r8kC0KCPFy5/3B6KL6j9wG1DbLif6NnJc1+b17z0aLaw3LSMZCIaSIdVvrNgGMqIe194= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AzZg7PrB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AzZg7PrB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 872D3C19422; Fri, 9 Jan 2026 15:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767973303; bh=0wcHDgSpLs2pCXUqhBdUziVISHn2lfYudCfXokz2QnY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AzZg7PrB8vx8IBb+mam7tVaJV1O/f1MMHej4A2MizKbwLWDpHmsHMBtb6RIfcHWe2 m0bKVZ8sH6VRJ8KTfAwrZIGe6om57hjxfWN8CLYGYx7nVanyfPIu7u6V29NqBBu4/v NcR5bB2/yiGCz6nXfNc7xeN9KaK0qV7nzyFaQQfvvOe+CbYDn1xDl/fisqQzN/7l/3 UipsOz/YVA1dGJzWzFGfWvlCWO3TzxG9BR/kgEqrsuqvQqUhwmOW4xHP6RcbYGT6fp Of+y6/d3N1CQFv5SyRgMO5ZYfz2HIQ7NtF1ontmeeVMuC805Sc91gKALELWoJSkNef 9I6GNiLTG68cQ== Date: Fri, 9 Jan 2026 15:41:39 +0000 From: Lee Jones To: Felix Gu Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd:tc3589:fix a potential resource leak Message-ID: <20260109154139.GA1808297@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, 26 Dec 2025, Felix Gu wrote: > Use devm_request_threaded_irq to repalce request_threaded_irq to avoid > a potential resource leak. > > Signed-off-by: Felix Gu > --- > drivers/mfd/tc3589x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c > index 2d4eb771e230..e3aaeb4701b8 100644 > --- a/drivers/mfd/tc3589x.c > +++ b/drivers/mfd/tc3589x.c > @@ -410,7 +410,7 @@ static int tc3589x_probe(struct i2c_client *i2c) > if (ret) > return ret; > > - ret = request_threaded_irq(tc3589x->i2c->irq, NULL, tc3589x_irq, > + ret = devm_request_threaded_irq(tc3589x->dev, tc3589x->i2c->irq, NULL, tc3589x_irq, > IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > "tc3589x", tc3589x); These two lines no longer line-up. Please fix. > if (ret) { > > --- > base-commit: 3d845d25026c5b1050e927e3ee4c515977a9b490 > change-id: 20251226-tc3589x-fix-50ce3358c7bf > > Best regards, > -- > Felix Gu > -- Lee Jones [李琼斯]