From: Steven Rostedt <rostedt@goodmis.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux trace kernel <linux-trace-kernel@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast
Date: Sun, 11 Jan 2026 17:09:53 -0500 [thread overview]
Message-ID: <20260111170953.49127c00@fedora> (raw)
In-Reply-To: <CAADnVQJ_L_TvFogq0+-qOH=vxe5bzU9iz3c-6-N7VFYE6cBnjQ@mail.gmail.com>
On Sun, 11 Jan 2026 12:04:51 -0800
Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> The diff has nothing to do with bpf needs and/or bpf internals.
> It's really about being a good citizen of PREEMP_RT.
> bpf side already does migrate_disable,
> rcu_read_lock, srcu_fast/task_trace when necessary.
> Most of the time we don't rely on any external preempt state or rcu/srcu.
> Removing guard(preempt_notrace)(); from tracepoint invocation
> would be just fine for bpf. Simple remove will trigger bug
> on cant_sleep(), but that's a trivial fix.
Oh, so you are OK replacing the preempt_disable in the tracepoint
callbacks with fast SRCU?
Then I guess we can simply do that. Would it be fine to do that for
both RT and non-RT? That will simplify the code quite a bit.
-- Steve
next prev parent reply other threads:[~2026-01-11 22:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 3:05 [PATCH v5] tracing: Guard __DECLARE_TRACE() use of __DO_TRACE_CALL() with SRCU-fast Steven Rostedt
2026-01-09 14:40 ` Mathieu Desnoyers
2026-01-09 17:21 ` Steven Rostedt
2026-01-09 18:58 ` Mathieu Desnoyers
2026-01-13 13:56 ` Sebastian Andrzej Siewior
2026-01-09 19:10 ` Alexei Starovoitov
2026-01-09 19:19 ` Steven Rostedt
2026-01-09 20:21 ` Mathieu Desnoyers
2026-01-09 21:02 ` Steven Rostedt
2026-01-12 7:23 ` Menglong Dong
2026-01-12 15:31 ` Peter Zijlstra
2026-01-12 15:36 ` Steven Rostedt
2026-01-12 15:44 ` Peter Zijlstra
2026-01-09 21:54 ` Alexei Starovoitov
2026-01-09 22:00 ` Steven Rostedt
2026-01-09 22:18 ` Alexei Starovoitov
2026-01-09 22:31 ` Mathieu Desnoyers
2026-01-09 22:33 ` Steven Rostedt
2026-01-09 22:39 ` Steven Rostedt
2026-01-10 0:35 ` Alexei Starovoitov
2026-01-10 16:14 ` Steven Rostedt
2026-01-11 20:04 ` Alexei Starovoitov
2026-01-11 22:09 ` Steven Rostedt [this message]
2026-01-11 23:38 ` Alexei Starovoitov
2026-01-12 13:53 ` Steven Rostedt
2026-01-12 17:19 ` Alexei Starovoitov
2026-01-13 14:23 ` Sebastian Andrzej Siewior
2026-01-13 23:44 ` Alexei Starovoitov
2026-01-09 19:19 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260111170953.49127c00@fedora \
--to=rostedt@goodmis.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=paulmck@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.