From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Eric Dumazet" <edumazet@google.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
"Jakub Kicinski" <kuba@kernel.org>,
"Maciej Żenczykowski" <maze@google.com>,
"Will Deacon" <will@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>
Subject: Re: include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar
Date: Sun, 11 Jan 2026 18:51:39 +0000 [thread overview]
Message-ID: <20260111185139.GI3634291@ZenIV> (raw)
In-Reply-To: <20260111182010.GH3634291@ZenIV>
On Sun, Jan 11, 2026 at 06:20:10PM +0000, Al Viro wrote:
> Guys, do you have any problems with replacing __unqual_scalar_typeof()
> uses with that thing?
>
> As in,#ifndef __smp_load_acquire
> #define __smp_load_acquire(p) \
> ({ \
> unqual_non_array(__typeof__(*p)) ___p1 = READ_ONCE(*p); \
> ...
>
> Objections? IMO it's more palatable than current __unqual_scalar_typeof()...
Argh... gcc prior to 8.4 fucks it up, and our minimum is 8.1 ;-/
Pity, that... I still think it's worth keeping in mind for when
we bump the minimal gcc revision, though.
FWIW, with clang it works all way back at least to 3.1; icc - at least
to 13.0.1...
next prev parent reply other threads:[~2026-01-11 18:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-10 21:06 include/net/sock.h:2100:16: sparse: sparse: cast to non-scalar kernel test robot
2026-01-10 22:15 ` Al Viro
2026-01-10 22:35 ` Al Viro
2026-01-11 10:08 ` Eric Dumazet
2026-01-12 12:33 ` Peter Zijlstra
2026-01-11 18:20 ` Al Viro
2026-01-11 18:51 ` Al Viro [this message]
2026-01-12 12:37 ` Peter Zijlstra
2026-01-12 15:02 ` Will Deacon
2026-01-12 19:21 ` Al Viro
2026-01-12 21:16 ` Al Viro
2026-01-12 22:39 ` David Laight
2026-01-13 0:28 ` Al Viro
2026-01-12 12:32 ` Peter Zijlstra
2026-01-12 19:30 ` Al Viro
2026-01-13 15:27 ` Peter Zijlstra
2026-01-12 0:49 ` Philip Li
-- strict thread matches above, loose matches on Subject: below --
2025-12-06 10:09 kernel test robot
2025-08-25 4:45 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260111185139.GI3634291@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maze@google.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.