From: Greg KH <gregkh@linuxfoundation.org>
To: Tejas Chaudhari <tejaschaudhari038@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org,
sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com
Subject: Re: [PATCH] staging: sm750fb: rename fixId to fix_id
Date: Sun, 11 Jan 2026 13:51:54 +0100 [thread overview]
Message-ID: <2026011147-chaperone-omen-dad4@gregkh> (raw)
In-Reply-To: <20251223192703.16502-1-tejaschaudhari038@gmail.com>
On Wed, Dec 24, 2025 at 12:57:03AM +0530, Tejas Chaudhari wrote:
> Rename the local fixId array to fix_id to follow
> kernel naming conventions and fix a checkpatch
> CamelCase warning.
>
> No functional changes.
>
> Signed-off-by: Tejas Chaudhari <tejaschaudhari038@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 15b5de33b..7afb58561 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
> "kernel HELPERS prepared vesa_modes",
> };
>
> - static const char *fixId[2] = {
> + static const char *fix_id[2] = {
> "sm750_fb1", "sm750_fb2",
> };
>
> @@ -862,7 +862,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
> fix->ywrapstep = crtc->ywrapstep;
> fix->accel = FB_ACCEL_SMI;
>
> - strscpy(fix->id, fixId[index], sizeof(fix->id));
> + strscpy(fix->id, fix_id[index], sizeof(fix->id));
>
> fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
> pr_info("fix->smem_start = %lx\n", fix->smem_start);
> --
> 2.39.5 (Apple Git-154)
>
Does not apply to the tree anymore :(
next prev parent reply other threads:[~2026-01-11 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 19:27 [PATCH] staging: sm750fb: rename fixId to fix_id Tejas Chaudhari
2026-01-11 12:51 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-23 19:24 Tejas Chaudhari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011147-chaperone-omen-dad4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=tejaschaudhari038@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.