All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marnix Rijnart <marnix.rijnart@iwell.eu>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	regressions@lists.linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH v2] serial: 8250_pci: Fix broken RS485 for F81504/508/512
Date: Sun, 11 Jan 2026 15:16:31 +0100	[thread overview]
Message-ID: <2026011158--1d2d@gregkh> (raw)
In-Reply-To: <20260111135933.31316-1-marnix.rijnart@iwell.eu>

On Sun, Jan 11, 2026 at 02:59:17PM +0100, Marnix Rijnart wrote:
> v1: https://patch.msgid.link/20250923221756.26770-1-marnix.rijnart@iwell.eu
> Changes: 
>  * Added fixes tags
>  * Cc stable
> 
> Commit 4afeced ("serial: core: fix sanitizing check for RTS settings")

Please use more digits here, "4afeced55baa", like you did in the Fixes:
lines.

> introduced a regression making it impossible to unset
> SER_RS485_RTS_ON_SEND from userspace if SER_RS485_RTS_AFTER_SEND is
> unsupported. Because these devices need RTS to be low on TX (fecf27a)
> they are effectively broken.
> 
> The hardware supports both RTS_ON_SEND and RTS_AFTER_SEND,
> so fix this by announcing support for SER_RS485_RTS_AFTER_SEND,
> similar to commit 068d35a.

You can line-wrap at 72 columns, and again, use more digits for the
commit, and spell out the full name of the commit.

> Fixes: 4afeced55baa ("serial: core: fix sanitizing check for RTS settings")
> Fixes: fecf27a373f5 ("serial: 8250_pci: add RS485 for F81504/508/512")
> Cc: stable@vger.kernel.org

So where does this need to be backported to, where the first commit is,
or the second?

thanks,

greg k-h

      parent reply	other threads:[~2026-01-11 14:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11 13:59 [PATCH v2] serial: 8250_pci: Fix broken RS485 for F81504/508/512 Marnix Rijnart
2026-01-11 14:14 ` Greg Kroah-Hartman
2026-01-11 14:16 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026011158--1d2d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marnix.rijnart@iwell.eu \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.