From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C671AD25030 for ; Mon, 12 Jan 2026 01:31:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:Message-Id:Date:To:Sender: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=Ksa9DSIS2I5nUZJN+XpbJEt5RTze+lBfaRALHYx8/Fs=; b=HORdZSfL9IrmuEVSfAeBTo0jUk SQ2j8rybeAQWDrjdjW1p99WHxz7S47Hgi4tRo/sajFL8/oMT0um9TK2KN2lSxFwkBXM5gEbZB2+7d pjgmw8/6Xd17Za7iQl22lxOIsHOsMvVop9WPJwG7IWAHxLffztgIIXu9f44ITNatH+j8=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vf6ly-0006aq-Ds; Mon, 12 Jan 2026 01:31:11 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vf6lw-0006aj-TQ for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Jan 2026 01:31:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J8YD+mhgx8Q/OEdEYj5CeNbIlgUI7TUUkdP7EdA1FRg=; b=PBZtntlR41gHLGDSKbR+iImEEm lH+4O8EkZbhszuOwtolBMv/WwBNYArBGXAw7Fq71u7pCBOFd2ePkYu1xv0gKpGJIS9etBuzINVix9 yv5JcuDO76Kheflz9uarLtcRrYL+E2lI0wgKjgHoNfvDUn5WBLwIscfd/p/SQNhv2I5Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=J8YD+mhgx8Q/OEdEYj5CeNbIlgUI7TUUkdP7EdA1FRg=; b=P OxLKjT7z9arUOQs7WwkJ5hFHciDThrVIjLI2JGBabDHIXrRrgq4whQJ37tS5DEbPQqGIpSQ7Y5gFr 97SlWSuIJEbsRrNv2IS2BV0O/pv8kkQsiejNtRvsGXX+j19AyIJGydJzzqjBTQXLqXguPJi6oBLhR SsuDGDU9hyhPVE6o=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vf6lx-0000td-5U for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Jan 2026 01:31:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7D2A260159 for ; Mon, 12 Jan 2026 01:30:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7D5DC4CEF7; Mon, 12 Jan 2026 01:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768181457; bh=zb6R+J9kkW67RrSB5zaxDMsHKu/A1fi9UpiW2r/jkL0=; h=From:To:Cc:Subject:Date:From; b=KnXVJaqeBj6/lKmz8vDUkzLzhMLuTLlQRKU7DOQdGOFGcY8sUDiwWjlqpmyrrvnbI RPx9HMm1hzTHZmUhnc3yM97p9c+EPhx/2h5Mmuuqq3in2YSYOnXgUUt+/yZQ8CyhrC KhiuSAqtItTsX+G0IrshuJ1VHHBF0PBliDhbWKNpn7x+X6ah5JfnZboK06rtXHnB1R AOmyGVrf+TnElXj2nG0fhNHlvQSxhoTP/ApO+Le/4/5HokqGHXtnK5LtjUY0fPbYuu eZ05WaCKYJbxi+h6shr8fb3M+7YyW0XQ1eb9JhUPpKd521B6VznEGyw3wAFGHSzSHJ Q2YSbRnghyRcg== To: jaegeuk@kernel.org Date: Mon, 12 Jan 2026 09:30:52 +0800 Message-Id: <20260112013052.7623-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Headers-End: 1vf6lx-0000td-5U Subject: [f2fs-dev] [PATCH] f2fs: fix to unlock folio in f2fs_read_data_large_folio() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net We missed to unlock folio in error path of f2fs_read_data_large_folio(), fix it. With below testcase, it can reproduce the bug. touch /mnt/f2fs/file truncate -s $((1024*1024*1024)) /mnt/f2fs/file f2fs_io setflags immutable /mnt/f2fs/file sync echo 3 > /proc/sys/vm/drop_caches time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 f2fs_io clearflags immutable /mnt/f2fs/file echo 1 > /proc/sys/vm/drop_caches time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 Signed-off-by: Chao Yu --- Changelog: - this patch is based on Nanzhe Zhao's patchset fs/f2fs/data.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index eeeb70bff101..a2c4769d0ae1 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2462,11 +2462,11 @@ static int f2fs_read_data_large_folio(struct inode *inode, int ret = 0; bool folio_in_bio; - if (!IS_IMMUTABLE(inode)) - return -EOPNOTSUPP; - - if (f2fs_compressed_file(inode)) + if (!IS_IMMUTABLE(inode) || f2fs_compressed_file(inode)) { + if (folio) + folio_unlock(folio); return -EOPNOTSUPP; + } map.m_seg_type = NO_CHECK_TYPE; @@ -2569,22 +2569,18 @@ static int f2fs_read_data_large_folio(struct inode *inode, last_block_in_bio = block_nr; } trace_f2fs_read_folio(folio, DATA); - if (rac) { - if (!folio_in_bio) { - if (!ret) - folio_mark_uptodate(folio); - folio_unlock(folio); - } - folio = readahead_folio(rac); - goto next_folio; - } + err_out: - /* Nothing was submitted. */ - if (!bio) { + if (!folio_in_bio) { if (!ret) folio_mark_uptodate(folio); folio_unlock(folio); - return ret; + if (ret) + return ret; + } + if (rac) { + folio = readahead_folio(rac); + goto next_folio; } out: f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA); -- 2.40.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51223500948 for ; Mon, 12 Jan 2026 01:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768181458; cv=none; b=tDBlm96pDXI8rXC6ewogquDKbjUe0xkWHeUnjZ8w8etxJrTqLVsrfFx5wvlTu7IShH/XrbXEoauQ5QFiytpayZKl2Jhl7bslN5dBIF4Ud/FdqPzYrMX5XpQZlnQLrvfUtSB3XfXi4NfQdHqvA1kibYYo0amESDKVfkjad9oO3GQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768181458; c=relaxed/simple; bh=zb6R+J9kkW67RrSB5zaxDMsHKu/A1fi9UpiW2r/jkL0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rm+fRjqrIG3en1b7zbBF6+928FB075/o8F0g+lnpARwQpKw9v4BkcMlv6C7HuWkkCwl7SwzG3wRIov31K3tflZT5D2PM3vQZ7Shtq7l9MGFzLPmu2BLQgNh7PkGtXze+d+3SZsdb/SKPdYVwdvxX3rZd5GkAWIQqB7bHR6VEfDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KnXVJaqe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KnXVJaqe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7D5DC4CEF7; Mon, 12 Jan 2026 01:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768181457; bh=zb6R+J9kkW67RrSB5zaxDMsHKu/A1fi9UpiW2r/jkL0=; h=From:To:Cc:Subject:Date:From; b=KnXVJaqeBj6/lKmz8vDUkzLzhMLuTLlQRKU7DOQdGOFGcY8sUDiwWjlqpmyrrvnbI RPx9HMm1hzTHZmUhnc3yM97p9c+EPhx/2h5Mmuuqq3in2YSYOnXgUUt+/yZQ8CyhrC KhiuSAqtItTsX+G0IrshuJ1VHHBF0PBliDhbWKNpn7x+X6ah5JfnZboK06rtXHnB1R AOmyGVrf+TnElXj2nG0fhNHlvQSxhoTP/ApO+Le/4/5HokqGHXtnK5LtjUY0fPbYuu eZ05WaCKYJbxi+h6shr8fb3M+7YyW0XQ1eb9JhUPpKd521B6VznEGyw3wAFGHSzSHJ Q2YSbRnghyRcg== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH] f2fs: fix to unlock folio in f2fs_read_data_large_folio() Date: Mon, 12 Jan 2026 09:30:52 +0800 Message-Id: <20260112013052.7623-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We missed to unlock folio in error path of f2fs_read_data_large_folio(), fix it. With below testcase, it can reproduce the bug. touch /mnt/f2fs/file truncate -s $((1024*1024*1024)) /mnt/f2fs/file f2fs_io setflags immutable /mnt/f2fs/file sync echo 3 > /proc/sys/vm/drop_caches time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 f2fs_io clearflags immutable /mnt/f2fs/file echo 1 > /proc/sys/vm/drop_caches time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 time dd if=/mnt/f2fs/file of=/dev/null bs=1M count=1024 Signed-off-by: Chao Yu --- Changelog: - this patch is based on Nanzhe Zhao's patchset fs/f2fs/data.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index eeeb70bff101..a2c4769d0ae1 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2462,11 +2462,11 @@ static int f2fs_read_data_large_folio(struct inode *inode, int ret = 0; bool folio_in_bio; - if (!IS_IMMUTABLE(inode)) - return -EOPNOTSUPP; - - if (f2fs_compressed_file(inode)) + if (!IS_IMMUTABLE(inode) || f2fs_compressed_file(inode)) { + if (folio) + folio_unlock(folio); return -EOPNOTSUPP; + } map.m_seg_type = NO_CHECK_TYPE; @@ -2569,22 +2569,18 @@ static int f2fs_read_data_large_folio(struct inode *inode, last_block_in_bio = block_nr; } trace_f2fs_read_folio(folio, DATA); - if (rac) { - if (!folio_in_bio) { - if (!ret) - folio_mark_uptodate(folio); - folio_unlock(folio); - } - folio = readahead_folio(rac); - goto next_folio; - } + err_out: - /* Nothing was submitted. */ - if (!bio) { + if (!folio_in_bio) { if (!ret) folio_mark_uptodate(folio); folio_unlock(folio); - return ret; + if (ret) + return ret; + } + if (rac) { + folio = readahead_folio(rac); + goto next_folio; } out: f2fs_submit_read_bio(F2FS_I_SB(inode), bio, DATA); -- 2.40.1