From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86EB9D26D97 for ; Mon, 12 Jan 2026 10:02:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E301310E0DC; Mon, 12 Jan 2026 10:02:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="GLo7Tw3K"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 846CC10E316 for ; Mon, 12 Jan 2026 10:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1768212170; bh=l0pv5pZ/xVnRRZcmyOOTRtfEyklwaw4RDdM9CvaIT6Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GLo7Tw3KqP3Eh/veXc8DC7dOZX+4jgHJWeF18Yvc4sh759WqvuvrF8qrNzWchqdCK tO8EuvRyNVkCZG0KMoQHKws7I+PnQXNu7+jJP0bgA6hYMifdqz6MxaoVda5wYi7+zi LqYXEID5y0VUy3+DYZPrS58ISnelsQktyrIaaQI65EU4EFo0dQMfBUPnwJ/zZr6Db7 V+9rsm2hH2NNnep2Yb9tOrQnk3duF+mBUB+k4N8q0Z8lItbBHU/hqGfeM3UVeweIfD CTQ+YV1mDCNTU0XyZLgrjen1/0F7ZJlas98kueO8HO0BXv4TPBCsftK0d5Iyto95YO immHd3GawtijQ== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4F34E17E0E30; Mon, 12 Jan 2026 11:02:49 +0100 (CET) Date: Mon, 12 Jan 2026 11:02:43 +0100 From: Boris Brezillon To: Alice Ryhl Cc: Steven Price , Liviu Dudau , "=?UTF-8?B?QWRyacOhbg==?= Larumbe" , dri-devel@lists.freedesktop.org, David Airlie , Simona Vetter , Akash Goel , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Osipenko , Chris Diamand , Danilo Krummrich , Matthew Brost , "Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?=" , kernel@collabora.com Subject: Re: [PATCH v1 1/9] drm/gem: Consider GEM object reclaimable if shrinking fails Message-ID: <20260112110243.6d2a762b@fedora> In-Reply-To: References: <20260109130801.1239558-1-boris.brezillon@collabora.com> <20260109130801.1239558-2-boris.brezillon@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 12 Jan 2026 09:25:04 +0000 Alice Ryhl wrote: > On Fri, Jan 09, 2026 at 02:07:53PM +0100, Boris Brezillon wrote: > > If the object wasn't moved to a different LRU after the shrink callback > > is called, it means the buffer is still reclaimable. Update the remaining > > counter to reflect that. > > > > Signed-off-by: Boris Brezillon > > Should this have a Fixes:? If we wanted one, that would be e7c2af13f811 ("drm/gem: Add LRU/shrinker helper"), but I'm still not sure what the original intent was, so let's wait for Rob to confirm that a transient reclaim failures (most likely an inner lock that couldn't be acquired with a _try_lock()) should count as reclaimable.