From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A00437F8A5; Mon, 12 Jan 2026 17:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768240037; cv=none; b=PuPKvl/w0ZjN4O9gxx704zaRpmEvHOUwAoLOQvyMuFjVTL5mBRL36fUgigObpohMY3xSfRxn3iaDosDVF4ivvrZcajft4lW8KT0unBqjXUz6KPTq5RVrSptVtH9aEVvWbVbeoSjElgoAVjjkGXi5Zv36FQhZyNewXVijuzWUhOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768240037; c=relaxed/simple; bh=7CV8d5ZLjZnsixivTyttzKYK+F3Fykxp76GMWvkN/D4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I9ULnNTYTa/kuRpOjQFVcqjPPQwTrgLmzVO81S4i9DfjriYhXSf1dt3bcL6Flu5p0Pcrdy6EuLs2PTscebntKyZuHqTT1u7D7a2Zd4dCy9TGpxtV0efv5qaIWCnq0yLNVJ8L3RJPGVqavIvVoIxvwzq3tf3BwM/tPle7InY550M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aTgRgnsL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aTgRgnsL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C6FAC19425; Mon, 12 Jan 2026 17:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768240037; bh=7CV8d5ZLjZnsixivTyttzKYK+F3Fykxp76GMWvkN/D4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aTgRgnsLIoHdfPZ7yUZk1X/iiP+32IhZKLwoqdUUFGafNUBLN24n7VykD2UAKgLzh g3/B9h94Nlm3hReKMPuS5PD7kZDuX+DkPJmVzmE+MQKg7jUelRju6q9Gu42VJ/8VOL FvFsTK5nM3QnM/vQjaPk4ASdRJ/7OiFgvhmDZpFJr5byy1sHFJvZ/pZx0ygv9qlc/9 G4hld9ftSDKcjfhAHEI3soKcPqgCuXJRFNYIaLfQqsF3/POXznYw7tmuxgvOpWcota znYTlLgv/VmymYtK3G55pJO88ys77Fs+imwAg7lmSsVTpyRaP/zW60ZNipesBXBP1y RcDXNiV38SE3A== From: Chuck Lever To: vira, Christian Brauner , Jan Kara Cc: , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org, , linux-f2fs-devel@lists.sourceforge.net, hirofumi@mail.parknet.co.jp, linkinjeon@kernel.org, sj1557.seo@samsung.com, yuezhang.mo@sony.com, almaz.alexandrovich@paragon-software.com, slava@dubeyko.com, glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu, adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org, pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, trondmy@kernel.org, anna@kernel.org, jaegeuk@kernel.org, chao@kernel.org, hansg@kernel.org, senozhatsky@chromium.org, Chuck Lever Subject: [PATCH v3 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Date: Mon, 12 Jan 2026 12:46:29 -0500 Message-ID: <20260112174629.3729358-17-cel@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112174629.3729358-1-cel@kernel.org> References: <20260112174629.3729358-1-cel@kernel.org> Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever ksmbd hard-codes FILE_CASE_SENSITIVE_SEARCH and FILE_CASE_PRESERVED_NAMES in FS_ATTRIBUTE_INFORMATION responses, incorrectly indicating all exports are case-sensitive. This breaks clients accessing case-insensitive filesystems like exFAT or ext4/f2fs directories with casefold enabled. Query actual case behavior via vfs_fileattr_get() and report accurate attributes to SMB clients. Filesystems without ->fileattr_get continue reporting default POSIX behavior (case-sensitive, case-preserving). SMB's FS_ATTRIBUTE_INFORMATION reports per-share attributes from the share root, not per-file. Shares mixing casefold and non-casefold directories report the root directory's behavior. Signed-off-by: Chuck Lever --- fs/smb/server/smb2pdu.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 2fcd0d4d1fb0..2db189fef4da 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -13,6 +13,7 @@ #include #include #include +#include #include "glob.h" #include "smbfsctl.h" @@ -5486,16 +5487,33 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work, case FS_ATTRIBUTE_INFORMATION: { FILE_SYSTEM_ATTRIBUTE_INFO *info; + struct file_kattr fa = {}; size_t sz; + u32 attrs; + int err; info = (FILE_SYSTEM_ATTRIBUTE_INFO *)rsp->Buffer; - info->Attributes = cpu_to_le32(FILE_SUPPORTS_OBJECT_IDS | - FILE_PERSISTENT_ACLS | - FILE_UNICODE_ON_DISK | - FILE_CASE_PRESERVED_NAMES | - FILE_CASE_SENSITIVE_SEARCH | - FILE_SUPPORTS_BLOCK_REFCOUNTING); + attrs = FILE_SUPPORTS_OBJECT_IDS | + FILE_PERSISTENT_ACLS | + FILE_UNICODE_ON_DISK | + FILE_SUPPORTS_BLOCK_REFCOUNTING; + err = vfs_fileattr_get(path.dentry, &fa); + if (err && err != -ENOIOCTLCMD) { + path_put(&path); + return err; + } + if (err == -ENOIOCTLCMD) { + /* Default POSIX: case-sensitive and case-preserving */ + fa.case_insensitive = false; + fa.case_preserving = true; + } + if (!fa.case_insensitive) + attrs |= FILE_CASE_SENSITIVE_SEARCH; + if (fa.case_preserving) + attrs |= FILE_CASE_PRESERVED_NAMES; + + info->Attributes = cpu_to_le32(attrs); info->Attributes |= cpu_to_le32(server_conf.share_fake_fscaps); if (test_share_config_flag(work->tcon->share_conf, -- 2.52.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43A0ACF45B2 for ; Mon, 12 Jan 2026 17:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:References:In-Reply-To: Message-ID:Date:To:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uDLQvnkl1JLKb5/+SrYCtcL0rNwYhJYwhujwwCktnZM=; b=WT4KOoLXskyGzFAKNUa1V+MRMm +F1pL0n4NeblMO1g351gTd5+rfvTmdMHynEkGQ8zkZl0GVhi03hBI7keerHlr3ikcgwk9X2qFWWng 1jlp8TxH+2uVqlje3NyYUm/0bvFAi+5OnpY/7vGH5MZwi3sf5EYGU88Zeautd/Ong3J4=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vfM0m-00017L-VC; Mon, 12 Jan 2026 17:47:28 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vfM0m-00017C-CS for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Jan 2026 17:47:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xLGRo4+0mtQK4bNSe/J7Z8EFqVyNGgGjbBo7sJ2WQa8=; b=hamDxRukXBqS3vyC7enTNuD5Wi tmy2HRs2P30S36og9AHDRYba6q6Snm6XSJt/JiHlaxKWbxqXI6S1RFeOJPHJuffk8hGmd7n+XTXDs wLUNEjStP46jEufIl2dAd0JMI2m2gVL7WBkj2SuIpOpa6uHITvuPJ+hm2KgXyplQ2OYM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xLGRo4+0mtQK4bNSe/J7Z8EFqVyNGgGjbBo7sJ2WQa8=; b=dh0F/UeH/GffD+MfIuh/j9uLbT HmBXbZOw9fqBEPzTBTNMMQYxZoQzHlYG5AkjPG8fCXF9tOyD6oSg61fWlr2lCDRm8rgyw2sqjeIN8 CIj17Ip9Ka3HmIQrun8yiegi4aaQUQtJ+fI2264GBJLP2Eav5gcbJuwqhoirv65l61+w=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vfM0l-0008V4-Ur for linux-f2fs-devel@lists.sourceforge.net; Mon, 12 Jan 2026 17:47:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8AC344415D; Mon, 12 Jan 2026 17:47:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C6FAC19425; Mon, 12 Jan 2026 17:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768240037; bh=7CV8d5ZLjZnsixivTyttzKYK+F3Fykxp76GMWvkN/D4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aTgRgnsLIoHdfPZ7yUZk1X/iiP+32IhZKLwoqdUUFGafNUBLN24n7VykD2UAKgLzh g3/B9h94Nlm3hReKMPuS5PD7kZDuX+DkPJmVzmE+MQKg7jUelRju6q9Gu42VJ/8VOL FvFsTK5nM3QnM/vQjaPk4ASdRJ/7OiFgvhmDZpFJr5byy1sHFJvZ/pZx0ygv9qlc/9 G4hld9ftSDKcjfhAHEI3soKcPqgCuXJRFNYIaLfQqsF3/POXznYw7tmuxgvOpWcota znYTlLgv/VmymYtK3G55pJO88ys77Fs+imwAg7lmSsVTpyRaP/zW60ZNipesBXBP1y RcDXNiV38SE3A== To: vira, Christian Brauner , Jan Kara Date: Mon, 12 Jan 2026 12:46:29 -0500 Message-ID: <20260112174629.3729358-17-cel@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112174629.3729358-1-cel@kernel.org> References: <20260112174629.3729358-1-cel@kernel.org> MIME-Version: 1.0 X-Headers-End: 1vfM0l-0008V4-Ur Subject: [f2fs-dev] [PATCH v3 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chuck Lever via Linux-f2fs-devel Reply-To: Chuck Lever Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org, almaz.alexandrovich@paragon-software.com, adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org, sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org, linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com, ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de, jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp, linux-nfs@vger.kernel.org, tytso@mit.edu, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, senozhatsky@chromium.org, Chuck Lever , hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com, trondmy@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Chuck Lever ksmbd hard-codes FILE_CASE_SENSITIVE_SEARCH and FILE_CASE_PRESERVED_NAMES in FS_ATTRIBUTE_INFORMATION responses, incorrectly indicating all exports are case-sensitive. This breaks clients accessing case-insensitive filesystems like exFAT or ext4/f2fs directories with casefold enabled. Query actual case behavior via vfs_fileattr_get() and report accurate attributes to SMB clients. Filesystems without ->fileattr_get continue reporting default POSIX behavior (case-sensitive, case-preserving). SMB's FS_ATTRIBUTE_INFORMATION reports per-share attributes from the share root, not per-file. Shares mixing casefold and non-casefold directories report the root directory's behavior. Signed-off-by: Chuck Lever --- fs/smb/server/smb2pdu.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 2fcd0d4d1fb0..2db189fef4da 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -13,6 +13,7 @@ #include #include #include +#include #include "glob.h" #include "smbfsctl.h" @@ -5486,16 +5487,33 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work, case FS_ATTRIBUTE_INFORMATION: { FILE_SYSTEM_ATTRIBUTE_INFO *info; + struct file_kattr fa = {}; size_t sz; + u32 attrs; + int err; info = (FILE_SYSTEM_ATTRIBUTE_INFO *)rsp->Buffer; - info->Attributes = cpu_to_le32(FILE_SUPPORTS_OBJECT_IDS | - FILE_PERSISTENT_ACLS | - FILE_UNICODE_ON_DISK | - FILE_CASE_PRESERVED_NAMES | - FILE_CASE_SENSITIVE_SEARCH | - FILE_SUPPORTS_BLOCK_REFCOUNTING); + attrs = FILE_SUPPORTS_OBJECT_IDS | + FILE_PERSISTENT_ACLS | + FILE_UNICODE_ON_DISK | + FILE_SUPPORTS_BLOCK_REFCOUNTING; + err = vfs_fileattr_get(path.dentry, &fa); + if (err && err != -ENOIOCTLCMD) { + path_put(&path); + return err; + } + if (err == -ENOIOCTLCMD) { + /* Default POSIX: case-sensitive and case-preserving */ + fa.case_insensitive = false; + fa.case_preserving = true; + } + if (!fa.case_insensitive) + attrs |= FILE_CASE_SENSITIVE_SEARCH; + if (fa.case_preserving) + attrs |= FILE_CASE_PRESERVED_NAMES; + + info->Attributes = cpu_to_le32(attrs); info->Attributes |= cpu_to_le32(server_conf.share_fake_fscaps); if (test_share_config_flag(work->tcon->share_conf, -- 2.52.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel