All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Chalios, Babis" <bchalios@amazon.es>
Cc: "robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Graf (AWS), Alexander" <graf@amazon.de>,
	"mzxreary@0pointer.de" <mzxreary@0pointer.de>,
	"Cali, Marco" <xmarcalx@amazon.co.uk>,
	"Woodhouse, David" <dwmw@amazon.co.uk>
Subject: Re: [PATCH v5 4/7] ptp: ptp_vmclock: Add device tree support
Date: Mon, 12 Jan 2026 19:46:19 -0800	[thread overview]
Message-ID: <20260112194619.70ed3a24@kernel.org> (raw)
In-Reply-To: <20260107132514.437-5-bchalios@amazon.es>

On Wed, 7 Jan 2026 13:26:01 +0000 Chalios, Babis wrote:
> +static int vmclock_setup_notification(struct device *dev,
> +				      struct vmclock_state *st)
> +{
> +	/* The device does not support notifications. Nothing else to do */
> +	if (!(le64_to_cpu(st->clk->flags) & VMCLOCK_FLAG_NOTIFICATION_PRESENT))
> +		return 0;
> +
> +	if (has_acpi_companion(dev)) {
> +		return vmclock_setup_acpi_notification(dev);
> +	} else {
> +		return vmclock_setup_of_notification(dev);
> +	}
> +
> +}
> +
> +
>  static void vmclock_put_idx(void *data)

Please run checkpatch.

CHECK: Blank lines aren't necessary before a close brace '}'
#109: FILE: drivers/ptp/ptp_vmclock.c:636:
+
+}

CHECK: Please don't use multiple blank lines
#111: FILE: drivers/ptp/ptp_vmclock.c:638:
+
+

  reply	other threads:[~2026-01-13  3:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 13:25 [PATCH v5 0/7] ptp: vmclock: Add VM generation counter and ACPI notification Chalios, Babis
2026-01-07 13:25 ` [PATCH v5 1/7] ptp: vmclock: add vm generation counter Chalios, Babis
2026-01-07 13:25 ` [PATCH v5 2/7] ptp: vmclock: support device notifications Chalios, Babis
2026-01-07 13:25 ` [PATCH v5 3/7] dt-bindings: ptp: Add amazon,vmclock Chalios, Babis
2026-01-07 13:26 ` [PATCH v5 4/7] ptp: ptp_vmclock: Add device tree support Chalios, Babis
2026-01-13  3:46   ` Jakub Kicinski [this message]
2026-01-07 13:26 ` [PATCH v5 5/7] ptp: ptp_vmclock: add 'VMCLOCK' to ACPI device match Chalios, Babis
2026-01-07 13:26 ` [PATCH v5 6/7] ptp: ptp_vmclock: remove dependency on CONFIG_ACPI Chalios, Babis
2026-01-07 13:26 ` [PATCH v5 7/7] ptp: ptp_vmclock: return TAI not UTC Chalios, Babis
2026-01-07 13:28 ` [PATCH v5 0/7] ptp: vmclock: Add VM generation counter and ACPI notification David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260112194619.70ed3a24@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=bchalios@amazon.es \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=dwmw@amazon.co.uk \
    --cc=edumazet@google.com \
    --cc=graf@amazon.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mzxreary@0pointer.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=xmarcalx@amazon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.