From: "Günther Noack" <gnoack3000@gmail.com>
To: Alejandro Colomar <alx@kernel.org>
Cc: "Mickaël Salaün" <mic@digikod.net>, linux-man@vger.kernel.org
Subject: Re: [PATCH man] landlock.7: Re-group description of IOCTL access right
Date: Tue, 13 Jan 2026 20:18:59 +0100 [thread overview]
Message-ID: <20260113.44fa9e91ef9a@gnoack.org> (raw)
In-Reply-To: <aWWJ5VhPwvKCVwRk@devuan>
Hi Alejandro!
On Tue, Jan 13, 2026 at 01:01:22AM +0100, Alejandro Colomar wrote:
> > Cc: Alejandro Colomar <alx.manpages@gmail.com>,
>
> Please remember to use <alx@kernel.org>. :)
Thanks, updated my helper scripts.
> > Subject: Re: [PATCH man] landlock.7: Re-group description of IOCTL access right
>
> Please use full path of the manual page (this can be done with the tab
> key --autocompletion--).
Done, will do.
> On Mon, Jan 12, 2026 at 08:45:17PM +0100, Günther Noack wrote:
> > Move the description of the LANDLOCK_ACCESS_FS_IOCTL_DEV access right
> > together with the file access rights.
> >
> > This group of access rights applies to files (in this case device
> > files), and they can be added to file or directory inodes using
> > landlock_add_rule(2). The check for that works the same for all file
> > access rights, including LANDLOCK_ACCESS_FS_IOCTL_DEV.
> >
> > Invoking ioctl(2) on directory FDs can not currently be restricted
> > with Landlock. Having it grouped separately in the documentation is a
> > remnant from earlier revisions of the LANDLOCK_ACCESS_FS_IOCTL_DEV
> > patch set.
>
> If I understand correctly, the behavior has never changed, and the
> documentation was wrong. Did I understand correctly?
Yes, that is correct. It made more sense in an earlier version of the
LANDLOCK_ACCESS_FS_IOCTL_DEV patch set, but then did not make sense in
the final version any more. I missed to keep the documentation up to
date.
> >
> > The same change was also done in kernel documentation, linked below.
> >
>
> Could you please add a Fixes: tag?
Done. Thanks for sharing the handy git alias as well - this is very
neat, I added that to my toolbox :)
Will send a v2 shortly.
–Günther
next prev parent reply other threads:[~2026-01-13 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 19:45 [PATCH man] landlock.7: Re-group description of IOCTL access right Günther Noack
2026-01-13 0:01 ` Alejandro Colomar
2026-01-13 19:18 ` Günther Noack [this message]
2026-01-13 21:34 ` Alejandro Colomar
-- strict thread matches above, loose matches on Subject: below --
2026-01-12 19:43 Günther Noack
2026-01-12 19:47 ` Günther Noack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260113.44fa9e91ef9a@gnoack.org \
--to=gnoack3000@gmail.com \
--cc=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.